[PATCH v3 1/2] newlib/configure.host: Remove obsolete definition of _I386MACH_ALLOW_HW_INTERRUPTS

[PATCH v3 1/2] newlib/configure.host: Remove obsolete definition of _I386MACH_ALLOW_HW_INTERRUPTS

[Joel Sherrill]

The *-*-rtems* targets defined this even though the conditional
was no longer present in i386/setjmp.S.
---
 newlib/configure.host | 2 --
 1 file changed, 2 deletions(-)

diff --git a/newlib/configure.host b/newlib/configure.host
index ba2d8c6..fb3362b 100644
--- a/newlib/configure.host
+++ b/newlib/configure.host
@@ -608,8 +608,6 @@ case "${host}" in
 	newlib_cflags="${newlib_cflags} -DCLOCK_PROVIDED -DMALLOC_PROVIDED -DEXIT_PROVIDED -DSIGNAL_PROVIDED -DREENTRANT_SYSCALLS_PROVIDED -DHAVE_NANOSLEEP -DHAVE_BLKSIZE -DHAVE_FCNTL -DHAVE_ASSERT_FUNC"
         # turn off unsupported items in posix directory 
 	newlib_cflags="${newlib_cflags} -D_NO_GETLOGIN -D_NO_GETPWENT -D_NO_GETUT -D_NO_GETPASS -D_NO_SIGSET -D_NO_WORDEXP -D_NO_POPEN -D_NO_POSIX_SPAWN"
-        # turn off using cli/sti in i386 setjmp/longjmp
-	newlib_cflags="${newlib_cflags} -D_I386MACH_ALLOW_HW_INTERRUPTS"
 	;;
 # VxWorks supplies its own version of malloc, and the newlib one
 # doesn't work because VxWorks does not have sbrk.
-- 
1.8.3.1

[PATCH v3 2/2] newlib/.../getreent.c: Do not define if __DYNAMIC_REENT__ is enabled

[Joel Sherrill]

RTEMS provides the option to have a global or per-thread reentrancy
as part of application configuration. As part of this, RTEMS provides
the implementation of __getreent() as appropriate. Allow the target
to determine if this method is present in libc.a.
---
 newlib/libc/reent/getreent.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/newlib/libc/reent/getreent.c b/newlib/libc/reent/getreent.c
index 60ae6fb..b42a88b 100644
--- a/newlib/libc/reent/getreent.c
+++ b/newlib/libc/reent/getreent.c
@@ -1,5 +1,13 @@
 /* default reentrant pointer when multithread enabled */
 
+#include <reent.h>
+
+#ifdef __DYNAMIC_REENT__
+
+int _dummy_getreent;
+
+#else
+
 #include <_ansi.h>
 #include <reent.h>
 
@@ -12,3 +20,5 @@ _DEFUN_VOID(__getreent)
 {
   return _impure_ptr;
 }
+
+#endif
-- 
1.8.3.1

Re: [PATCH v3 2/2] newlib/.../getreent.c: Do not define if __DYNAMIC_REENT__ is enabled

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

On Oct 27 16:32, Joel Sherrill wrote:
> RTEMS provides the option to have a global or per-thread reentrancy
> as part of application configuration. As part of this, RTEMS provides
> the implementation of __getreent() as appropriate. Allow the target
> to determine if this method is present in libc.a.
> ---
>  newlib/libc/reent/getreent.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/newlib/libc/reent/getreent.c b/newlib/libc/reent/getreent.c
> index 60ae6fb..b42a88b 100644
> --- a/newlib/libc/reent/getreent.c
> +++ b/newlib/libc/reent/getreent.c
> @@ -1,5 +1,13 @@
>  /* default reentrant pointer when multithread enabled */
>  
> +#include <reent.h>
> +
> +#ifdef __DYNAMIC_REENT__
> +
> +int _dummy_getreent;
> +
> +#else
> +
>  #include <_ansi.h>
>  #include <reent.h>
>  
> @@ -12,3 +20,5 @@ _DEFUN_VOID(__getreent)
>  {
>    return _impure_ptr;
>  }
> +
> +#endif
> -- 
> 1.8.3.1

NAK.  Not without explanation why you need a dummy_getreent.
This looks wrong.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH v3 2/2] newlib/.../getreent.c: Do not define if __DYNAMIC_REENT__ is enabled

[Sebastian Huber]

On 27/10/17 23:32, Joel Sherrill wrote:
> RTEMS provides the option to have a global or per-thread reentrancy
> as part of application configuration. As part of this, RTEMS provides
> the implementation of __getreent() as appropriate. Allow the target
> to determine if this method is present in libc.a.
> ---
>   newlib/libc/reent/getreent.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/newlib/libc/reent/getreent.c b/newlib/libc/reent/getreent.c
> index 60ae6fb..b42a88b 100644
> --- a/newlib/libc/reent/getreent.c
> +++ b/newlib/libc/reent/getreent.c
> @@ -1,5 +1,13 @@
>   /* default reentrant pointer when multithread enabled */
>   
> +#include <reent.h>
> +
> +#ifdef __DYNAMIC_REENT__
> +
> +int _dummy_getreent;
> +
> +#else
> +
>   #include <_ansi.h>
>   #include <reent.h>
>   
> @@ -12,3 +20,5 @@ _DEFUN_VOID(__getreent)
>   {
>     return _impure_ptr;
>   }
> +
> +#endif

__getreent() is only used if __DYNAMIC_REENT__ is defined:

#if defined(__DYNAMIC_REENT__) && !defined(__SINGLE_THREAD__)
#ifndef __getreent
   struct _reent * _EXFUN(__getreent, (void));
#endif
# define _REENT (__getreent())
#else /* __SINGLE_THREAD__ || !__DYNAMIC_REENT__ */
# define _REENT _impure_ptr
#endif /* __SINGLE_THREAD__ || !__DYNAMIC_REENT__ */

Why can't we delete this file (newlib/libc/reent/getreent.c)?

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

Re: [PATCH v3 2/2] newlib/.../getreent.c: Do not define if __DYNAMIC_REENT__ is enabled

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 833 bytes --]

On Nov  2 13:08, Sebastian Huber wrote:
> On 27/10/17 23:32, Joel Sherrill wrote:
> > [...]
> __getreent() is only used if __DYNAMIC_REENT__ is defined:
> 
> #if defined(__DYNAMIC_REENT__) && !defined(__SINGLE_THREAD__)
> #ifndef __getreent
>   struct _reent * _EXFUN(__getreent, (void));
> #endif
> # define _REENT (__getreent())
> #else /* __SINGLE_THREAD__ || !__DYNAMIC_REENT__ */
> # define _REENT _impure_ptr
> #endif /* __SINGLE_THREAD__ || !__DYNAMIC_REENT__ */
> 
> Why can't we delete this file (newlib/libc/reent/getreent.c)?

It was meant as the default implementation I think.  There may
even have been a time where Cygwin needed it, but AFAICS, this
doesn't apply anymore.

So, yeah, we may try to remove it and see what breaks...


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH v3 1/2] newlib/configure.host: Remove obsolete definition of _I386MACH_ALLOW_HW_INTERRUPTS

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

On Oct 27 16:32, Joel Sherrill wrote:
> The *-*-rtems* targets defined this even though the conditional
> was no longer present in i386/setjmp.S.
> ---
>  newlib/configure.host | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/newlib/configure.host b/newlib/configure.host
> index ba2d8c6..fb3362b 100644
> --- a/newlib/configure.host
> +++ b/newlib/configure.host
> @@ -608,8 +608,6 @@ case "${host}" in
>  	newlib_cflags="${newlib_cflags} -DCLOCK_PROVIDED -DMALLOC_PROVIDED -DEXIT_PROVIDED -DSIGNAL_PROVIDED -DREENTRANT_SYSCALLS_PROVIDED -DHAVE_NANOSLEEP -DHAVE_BLKSIZE -DHAVE_FCNTL -DHAVE_ASSERT_FUNC"
>          # turn off unsupported items in posix directory 
>  	newlib_cflags="${newlib_cflags} -D_NO_GETLOGIN -D_NO_GETPWENT -D_NO_GETUT -D_NO_GETPASS -D_NO_SIGSET -D_NO_WORDEXP -D_NO_POPEN -D_NO_POSIX_SPAWN"
> -        # turn off using cli/sti in i386 setjmp/longjmp
> -	newlib_cflags="${newlib_cflags} -D_I386MACH_ALLOW_HW_INTERRUPTS"
>  	;;
>  # VxWorks supplies its own version of malloc, and the newlib one
>  # doesn't work because VxWorks does not have sbrk.
> -- 
> 1.8.3.1

Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]