From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19084 invoked by alias); 3 Dec 2017 09:30:46 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 19066 invoked by uid 89); 3 Dec 2017 09:30:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*c:HgH, letter X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 03 Dec 2017 09:30:43 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5D91B883B8 for ; Sun, 3 Dec 2017 09:30:42 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-116-98.ams2.redhat.com [10.36.116.98]) by smtp.corp.redhat.com (Postfix) with ESMTP id 25EC35C3FF for ; Sun, 3 Dec 2017 09:30:42 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 60566A80612; Sun, 3 Dec 2017 10:30:41 +0100 (CET) Date: Sun, 03 Dec 2017 14:07:00 -0000 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: Unicode update of width and other character properties Message-ID: <20171203093041.GA7126@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20170807103034.GB18389@calimero.vinschen.de> <714181b2-c625-c911-8516-af4cba868f09@towo.net> <20170808083024.GA23158@calimero.vinschen.de> <0690aecd-4c52-edec-1ee8-af94b7f38e56@towo.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="opJtzjQTFsWo+cga" Content-Disposition: inline In-Reply-To: <0690aecd-4c52-edec-1ee8-af94b7f38e56@towo.net> User-Agent: Mutt/1.9.1 (2017-09-22) X-SW-Source: 2017/txt/msg01223.txt.bz2 --opJtzjQTFsWo+cga Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1855 Sorry for the late reply, I forgot this patch. On Aug 17 07:53, Thomas Wolff wrote: > [...] > I'm attaching my patches here for assessment. > I have revised table handling further, using gcc bit struct packing. The = two > big tables have a total size of 14340 bytes now, for Unicode 10.0. > I have fixed locale handling in the isw* and tow* functions, but I've not > yet changed JP conversion. Unfortunately, the routines from newlib/iconvd= ata > are not as straight-forward to be employed as I thought, because the work= on > multi-byte representations. > Also the mapping of ctype charsets (JIS, SJIS, EUC-JP) to the subsets > handled in iconvdata (JIS-201/208/212) is a little bit obscure. > Likewise obscure is the relation between newlib/iconvdata and > newlib/libc/iconv. This is really old stuff. I wonder if anybody is still using it with Unicode around for a long time... > To be on the safe side, I=E2=80=99m leaving the actual jp2uc conversion u= ntouched > for now, and I=E2=80=99ve just added a dummy back-conversion uc2jp with a= #warning. > If the #warning is ignored or removed, the non-Cygwin build should work as > before, fixing just locale handling. >=20 > I'm attaching the wcwidth part here, all patches are available at > http://towo.net/cygwin/Unicode_and_locale_tweaks.zip (don't fit in the > mailbox size limit). So why don't you use git send-email (ideally with a cover letter, see `git format-patch --cover-letter') instead of attaching the patches to a single email? This is the correct way of sending patch series and it gets you around the size limit. The below patches are missing a patch, last one is patch 3/4. Patches 2 and 3 are ok, afaics, but as for patch 1, why did you create an extra Makefile? This should be merged into string/Makefile.am. Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --opJtzjQTFsWo+cga Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJaI8RBAAoJEPU2Bp2uRE+g/2UP/0tEMZHPJO0aodYOjctyg6kr MD/Z2kBqLxrysvcDkUmH4Q97hUsmk9LEX0ORpAqNRUfeS6njpFSE7iFciCjz1IbN DQ/My5nTiB9+LPkz3hzmdNwb830jtdZ8tMG945FkFQGJcgeOOQs5NoqILl2waLZz CIHIcn5o+FvJr+10PbfCmzel4kq4qjOR2xShc+d2LtPqPbIPIVz6+TXnuWPGKeUQ KJpuqVUwfTQLWbmxfXe03rnQvWc8JrPrQzAIPofqFhAAMe1CKfjrCRJyBsvr25Ws KAHtLAPV88AAld3J+XJhm9KhpUPUFnnf4m6hpxJBxXXsRUwUUGX1AwU4ybsT/8ia ZgqKU24LWpMMngpXtTE31IwN5FP/Bt9S/jmrSf32Sf57/I3C2aiPeASJvRD4N5Hq o9TwiRyid38nfQz4a5Tx9PxpIdqR7bhsMBjeYKkaMeWYlpB+Nl321+V9AIa9zLX+ h/4mx+/76sKEZ2okTlB0V/0fFlhGzx4QhG4Cx9e4OYZrM5nZUsGfz3deNT0NUfN1 o1Myhrl3QHkrSXkaDqAsKgAw7wpPcjMcqduXcA8NRGTm0B2fEJ6mGdlKstpwIcor MM/TQpCn5Mn7tQFrGmzGg57HwVT2zODxrYcCffC/KqNDs1PWNiTApVITo6jmqyq9 PRU6ZPp8/epR6nsNFdoQ =3oKJ -----END PGP SIGNATURE----- --opJtzjQTFsWo+cga--