From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64126 invoked by alias); 4 Dec 2017 09:03:22 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 64112 invoked by uid 89); 4 Dec 2017 09:03:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=answered, everybody, integration, Hx-languages-length:2705 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Dec 2017 09:03:21 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 10305C0587C5 for ; Mon, 4 Dec 2017 09:03:20 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-116-58.ams2.redhat.com [10.36.116.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id A7FA1617A9 for ; Mon, 4 Dec 2017 09:03:19 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id F07C9A806C6; Mon, 4 Dec 2017 10:03:18 +0100 (CET) Date: Mon, 04 Dec 2017 09:05:00 -0000 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: Unicode update of width and other character properties Message-ID: <20171204090318.GB21472@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20170807103034.GB18389@calimero.vinschen.de> <714181b2-c625-c911-8516-af4cba868f09@towo.net> <20170808083024.GA23158@calimero.vinschen.de> <0690aecd-4c52-edec-1ee8-af94b7f38e56@towo.net> <20171203093041.GA7126@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vkogqOf2sHV7VnPd" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-SW-Source: 2017/txt/msg01229.txt.bz2 --vkogqOf2sHV7VnPd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2692 On Dec 3 15:07, Thomas Wolff wrote: > > On Aug 17 07:53, Thomas Wolff wrote: > > > [...] > > > I have fixed locale handling in the isw* and tow* functions, but I've= not > > > yet changed JP conversion. Unfortunately, the routines from newlib/ic= onvdata > > > are not as straight-forward to be employed as I thought, because the = work on > > > multi-byte representations. > > > Also the mapping of ctype charsets (JIS, SJIS, EUC-JP) to the subsets > > > handled in iconvdata (JIS-201/208/212) is a little bit obscure. > > > Likewise obscure is the relation between newlib/iconvdata and > > > newlib/libc/iconv. > > This is really old stuff. I wonder if anybody is still using it with > > Unicode around for a long time... I forgot to mention, I think your approach to keep this is the best one for now so as not to break anything for small targets. > > > To be on the safe side, I=E2=80=99m leaving the actual jp2uc conversi= on untouched > > > for now, and I=E2=80=99ve just added a dummy back-conversion uc2jp wi= th a #warning. > > > If the #warning is ignored or removed, the non-Cygwin build should wo= rk as > > > before, fixing just locale handling. > > >=20 > > > I'm attaching the wcwidth part here, all patches are available at > > > http://towo.net/cygwin/Unicode_and_locale_tweaks.zip (don't fit in the > > > mailbox size limit). > > So why don't you use git send-email (ideally with a cover letter, see > > `git format-patch --cover-letter') instead of attaching the patches to a > > single email? This is the correct way of sending patch series and it > > gets you around the size limit. > Because of: > LC_ALL=3DC git send-email > git: 'send-email' is not a git command. See 'git --help'. >=20 > Are there any working instructions for newlib contributions to be found > anywhere? Jon and Brian answered that. > > The below patches are missing a patch, last one is patch 3/4. > >=20 > > Patches 2 and 3 are ok, afaics, but as for patch 1, why did you create > > an extra Makefile? This should be merged into string/Makefile.am. > I was awaiting feedback before doing further integration work. The Makefi= le > includes test stuff and also the table generation. Would the generation be > invoked every time or rather called manually? Keeping generated files in the repos is frowned upon these days, but we're doing this for a pretty long time already and don't want everybody having to do these, mostly awkward steps. So, yeah, keeping the tables in the repo and manually calling the generation targets sounds right to me. Only maintainers (or interested parties) need to do this once in a while. Thanks, Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --vkogqOf2sHV7VnPd Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJaJQ9WAAoJEPU2Bp2uRE+gz7kQAJzXt21VU6tdwtdtYPfmrRnS i42z/3Bi4XZvKAwmUZv0XDNA6EvhOWmlZdGI/Jerb3A1+SIF6FjY+97WTy8X5lvM UafezhalRXkLj37ncyKTM/BUY7T7AOh/PpuUa9HJ+WUtkEr+rkuFznxivDTQNji+ t5jOCrx8mwpK/Uwi2wkQGC6Po1emWkabmKL/i/Snq1TsrzwRnhwVVd08Q80D4HSY gLBwN0tUA5s6efNF8pjTxdEWgiP3ow5HUTAPzVdWOrmUVqAgqxuh5vPLhCFtBXOO reF4GtE1CDD4/r8AEMRfvuiqYK6s+Poxl9Ey7hRqjgql0kF4cFhwX2amG4+R9my9 wjd6B6cKjMjkZBqBZmmpe0e6kiVwIGOvf9YMMrRo6N+lQiuzQ7WLIQlPp2LkMTT9 I6ZsPOOdlnGXtBplQmblSHAAFzGaZ0Vrxmq8KbdX+VSU7/ausc/bQxS5LL9jN4/S SMPWvKtrY7d5BPkiz/FyFQcCmWTi5/XAKNXguU82yJM/BZLj0kC+RxKEMCiPFLNu QV4UHC3RWNGTs/2KAUYIPqwpSPXIxt2aOkfF54MCUYZ145zhwIo+ILbqLy+8/KVo EqVlkgaNbftwcc47LAXOjhmDjnoTkIM9wXYsejtv63wqSu6kklzShhUJA3q0kslv ImWjUhxDGrZCt3eUlEg0 =+O0u -----END PGP SIGNATURE----- --vkogqOf2sHV7VnPd--