From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14089 invoked by alias); 26 Feb 2018 17:20:52 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 14033 invoked by uid 89); 26 Feb 2018 17:20:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=wcwidth, sendmail, categoriesc, gitpatch X-HELO: drew.franken.de Received: from mail-n.franken.de (HELO drew.franken.de) (193.175.24.27) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Feb 2018 17:20:48 +0000 Received: from perth.hirmke.de (aquarius.franken.de [193.175.24.89]) by mail-n.franken.de (Postfix) with ESMTP id 38739721E281E; Mon, 26 Feb 2018 18:20:43 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by perth.hirmke.de (Postfix) with ESMTP id 6FC8E861F69; Mon, 26 Feb 2018 18:20:42 +0100 (CET) X-Spam-Score: -2.899 Received: from perth.hirmke.de ([127.0.0.1]) by localhost (perth.hirmke.de [127.0.0.1]) (amavisd-new, port 10024) with LMTP id UFWqdO0mulLw; Mon, 26 Feb 2018 18:20:40 +0100 (CET) Received: from calimero.vinschen.de (calimero.vinschen.de [192.168.129.6]) by perth.hirmke.de (Postfix) with ESMTP id C169A861F44; Mon, 26 Feb 2018 18:20:40 +0100 (CET) Received: by calimero.vinschen.de (Postfix, from userid 500) id AF2C5A805FA; Mon, 26 Feb 2018 18:20:40 +0100 (CET) Date: Mon, 26 Feb 2018 17:20:00 -0000 From: Corinna Vinschen To: Thomas Wolff Cc: newlib@sourceware.org Subject: Re: Unicode update of width and other character properties Message-ID: <20180226172040.GD3037@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: Thomas Wolff , newlib@sourceware.org References: <20170807103034.GB18389@calimero.vinschen.de> <714181b2-c625-c911-8516-af4cba868f09@towo.net> <20170808083024.GA23158@calimero.vinschen.de> <0690aecd-4c52-edec-1ee8-af94b7f38e56@towo.net> <20171203093041.GA7126@calimero.vinschen.de> <20171204090318.GB21472@calimero.vinschen.de> <62dbc36b-7636-a358-355f-e588a325c924@towo.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DIOMP1UsTsWJauNi" Content-Disposition: inline In-Reply-To: <62dbc36b-7636-a358-355f-e588a325c924@towo.net> User-Agent: Mutt/1.9.2 (2017-12-15) X-SW-Source: 2018/txt/msg00179.txt.bz2 --DIOMP1UsTsWJauNi Content-Type: multipart/mixed; boundary="LpQ9ahxlCli8rRTG" Content-Disposition: inline --LpQ9ahxlCli8rRTG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2122 On Feb 25 18:14, Thomas Wolff wrote: > I have finally revamped, manually rebased, and repackaged my Unicode data > patches which I'll send in separate mail. > However, as I don't have a command-line sendmail set up (and apparently i= t's > not as easy as it used to be), > I'll send zip archives which contain git-patch files. No, sorry, but no. It's not that tricky to send standard git patch series, we're all doing this. If your MUA doesn't fit, use another MUA or *attach* the patches, one per mail. > There are two patches: > libc/string: wcwidth using generated width data, with data generated from > Unicode 10.0 > libc/ctype: isw* and tow* functions using generated case conversion and > character class data, with Unicode 10.0 data > For both, generation script and a Makefile.widthdata / Makefile.chardata = is > included. As these are to be used in the source directory, > not the binary target directory, in case of future Unicode update, they a= re > not related to the other Makefiles. Eh, what? If you read back, I had no problems with your patches 2 and 3, only with patch 1 adding new makefiles. So the only thing I actually asked for was to integrate the creation of the generated tables into Makefile.am and now you're telling me this is not what you changed...? > In ctype/, there is one new source (categories.c) which should be compiled > separately but although I tried to include it in Makefile.am, > I could not get the build process to compile it. So the current solution = is > to include it from one of the other sources (the one that also maintains = the > case conversion table). That's a workaround, not a solution. When you change Makefile.am you have to regenerate Makefile.in, obviously. However, since regenerating Makefile.in for newlib is (unfortunately, for historical reasons) non-obvious, you can just go ahead and manually add categories.* to Makefile.in where it belongs, kind of like the attached. A later regeneration run by one of the maintainers will fix the formatting so that's nothing to worry about. Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --LpQ9ahxlCli8rRTG Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename=x Content-Transfer-Encoding: quoted-printable Content-length: 2896 diff --git a/newlib/libc/ctype/Makefile.am b/newlib/libc/ctype/Makefile.am index 898693571bd1..fa6a70d3a1bf 100644 --- a/newlib/libc/ctype/Makefile.am +++ b/newlib/libc/ctype/Makefile.am @@ -24,6 +24,7 @@ if ELIX_LEVEL_1 ELIX_SOURCES =3D else ELIX_SOURCES =3D \ + categories.c \ isalnum_l.c \ isalpha_l.c \ isascii.c \ diff --git a/newlib/libc/ctype/Makefile.in b/newlib/libc/ctype/Makefile.in index 2b2331767a0f..9932a9494b09 100644 --- a/newlib/libc/ctype/Makefile.in +++ b/newlib/libc/ctype/Makefile.in @@ -79,7 +79,8 @@ am__objects_1 =3D lib_a-ctype_.$(OBJEXT) lib_a-isalnum.$(= OBJEXT) \ lib_a-ispunct.$(OBJEXT) lib_a-isspace.$(OBJEXT) \ lib_a-isxdigit.$(OBJEXT) lib_a-tolower.$(OBJEXT) \ lib_a-toupper.$(OBJEXT) -@ELIX_LEVEL_1_FALSE@am__objects_2 =3D lib_a-isalnum_l.$(OBJEXT) \ +@ELIX_LEVEL_1_FALSE@am__objects_2 =3D lib_a-categories.$(OBJEXT) \ +@ELIX_LEVEL_1_FALSE@ lib_a-isalnum_l.$(OBJEXT) \ @ELIX_LEVEL_1_FALSE@ lib_a-isalpha_l.$(OBJEXT) \ @ELIX_LEVEL_1_FALSE@ lib_a-isascii.$(OBJEXT) \ @ELIX_LEVEL_1_FALSE@ lib_a-isascii_l.$(OBJEXT) \ @@ -142,7 +143,7 @@ libctype_la_LIBADD =3D am__objects_3 =3D ctype_.lo isalnum.lo isalpha.lo iscntrl.lo isdigit.lo \ islower.lo isupper.lo isprint.lo ispunct.lo isspace.lo \ isxdigit.lo tolower.lo toupper.lo -@ELIX_LEVEL_1_FALSE@am__objects_4 =3D isalnum_l.lo isalpha_l.lo \ +@ELIX_LEVEL_1_FALSE@am__objects_4 =3D categories.lo isalnum_l.lo isalpha_l= .lo \ @ELIX_LEVEL_1_FALSE@ isascii.lo isascii_l.lo isblank.lo \ @ELIX_LEVEL_1_FALSE@ isblank_l.lo iscntrl_l.lo isdigit_l.lo \ @ELIX_LEVEL_1_FALSE@ islower_l.lo isupper_l.lo isprint_l.lo \ @@ -351,6 +352,7 @@ GENERAL_SOURCES =3D \ toupper.c =20 @ELIX_LEVEL_1_FALSE@ELIX_SOURCES =3D \ +@ELIX_LEVEL_1_FALSE@ categories.c \ @ELIX_LEVEL_1_FALSE@ isalnum_l.c \ @ELIX_LEVEL_1_FALSE@ isalpha_l.c \ @ELIX_LEVEL_1_FALSE@ isascii.c \ @@ -609,6 +611,12 @@ lib_a-toupper.o: toupper.c lib_a-toupper.obj: toupper.c $(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) = $(lib_a_CFLAGS) $(CFLAGS) -c -o lib_a-toupper.obj `if test -f 'toupper.c'; = then $(CYGPATH_W) 'toupper.c'; else $(CYGPATH_W) '$(srcdir)/toupper.c'; fi` =20 +lib_a-categories.o: categories.c + $(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) = $(lib_a_CFLAGS) $(CFLAGS) -c -o lib_a-categories.o `test -f 'categories.c' = || echo '$(srcdir)/'`categories.c + +lib_a-categories.obj: categories.c + $(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) = $(lib_a_CFLAGS) $(CFLAGS) -c -o lib_a-categories.obj `if test -f 'categorie= s.c'; then $(CYGPATH_W) 'categories.c'; else $(CYGPATH_W) '$(srcdir)/catego= ries.c'; fi` + lib_a-isalnum_l.o: isalnum_l.c $(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) = $(lib_a_CFLAGS) $(CFLAGS) -c -o lib_a-isalnum_l.o `test -f 'isalnum_l.c' ||= echo '$(srcdir)/'`isalnum_l.c =20 --LpQ9ahxlCli8rRTG-- --DIOMP1UsTsWJauNi Content-Type: application/pgp-signature; name="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAlqUQegACgkQ9TYGna5E T6BykxAAh7LJF0xpoxr/dyDOxHSYtT3wkoXUdtPecZuvDC77REO4uXsj7A7LF7xJ FkPh2kA3439SB5B+wUCnlmiJ2AG1LqjEGtGQepIZrtq0LPIq2UH1nLztiyHKyJLu aUepALL+lVPze5GJo8qUQVjeZ+cjKzFNZK2QN+A40yd1VgN1j7IaaM1TX+O6MYVr LaINHr+RWFOsKQagCy6VmjkD96RfCpPT8NNsPPDhY5szlRT70z6FxxwtkdB20FYj Icn2u/nLgTUELta3nbnlGplNy6ILXIfipiQUzSoZAybPIGcRsFKHV7PuYVdIXfaG 26cqyoi4McTA1VFvUkA/IOqDNgu2ojSL0uCanP7lQw1sBa94RZICaR27cZXYLjCw H3eIJX+zEhZqghk8YzrI5w3YRmW2OxnmRNjjA/OsVI6VV04kvLnQkllO42PFYtFy mCBlOJDS6Q2AZZom5/xruDVq0XeSDAf+S5bwhnJhL8zzcvafFgkCePBa2/DHzdCc bCXpmzstqtE26KL5zjSdYLdkj7D+N7aXh5mA4G2pDUVr/EcR94ZgBSkDN3ardfKK ij9naaW/aNsuRcwIKNRI6akhka81HLYDiYRTarl+iDrDdmfnX/re0LUauwoRsvfD 8hHe0BmK4rkvVL8pDHjXB4lgTSOFtPTfKZ59cZ20qxvwcqw7ypc= =EuCn -----END PGP SIGNATURE----- --DIOMP1UsTsWJauNi--