From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96246 invoked by alias); 13 Feb 2019 17:06:23 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 96238 invoked by uid 89); 13 Feb 2019 17:06:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Feb 2019 17:06:21 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A3328A7891 for ; Wed, 13 Feb 2019 17:06:20 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-116-96.ams2.redhat.com [10.36.116.96]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6220D6013F for ; Wed, 13 Feb 2019 17:06:20 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id C3CDEA8071B; Wed, 13 Feb 2019 18:06:18 +0100 (CET) Date: Wed, 13 Feb 2019 17:06:00 -0000 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 2/3] Move register_t to system-specific header Message-ID: <20190213170618.GD3718@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20190213131912.20445-1-sebastian.huber@embedded-brains.de> <20190213131912.20445-2-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HLsZ5Z1opAQvdr2J" Content-Disposition: inline In-Reply-To: <20190213131912.20445-2-sebastian.huber@embedded-brains.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2019/txt/msg00083.txt.bz2 --HLsZ5Z1opAQvdr2J Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1467 On Feb 13 14:19, Sebastian Huber wrote: > Signed-off-by: Sebastian Huber > --- > newlib/libc/include/machine/types.h | 2 ++ > newlib/libc/include/sys/types.h | 2 +- > newlib/libc/sys/rtems/include/machine/types.h | 2 ++ > winsup/cygwin/include/machine/types.h | 2 ++ > 4 files changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/newlib/libc/include/machine/types.h b/newlib/libc/include/ma= chine/types.h > index 19d0e8560..fab9cf72c 100644 > --- a/newlib/libc/include/machine/types.h > +++ b/newlib/libc/include/machine/types.h > @@ -11,3 +11,5 @@ typedef __uint64_t u_quad_t; > typedef __int64_t quad_t; > typedef quad_t * qaddr_t; > #endif > + > +typedef int register_t; > diff --git a/newlib/libc/include/sys/types.h b/newlib/libc/include/sys/ty= pes.h > index 2685df654..e05263d4e 100644 > --- a/newlib/libc/include/sys/types.h > +++ b/newlib/libc/include/sys/types.h > @@ -36,7 +36,7 @@ typedef __uint32_t u_int32_t; > #if ___int64_t_defined > typedef __uint64_t u_int64_t; > #endif > -typedef int register_t; > + > #define __BIT_TYPES_DEFINED__ 1 Why move this out here? Sure, it's wrong for 64 bit targets ATM, but moving it to rtems and Cygwin only means that the type suddenly disappears for other targets. Better just fix it here for all targets, including defining uregister_t if __BSD_VISIBLE. Thanks, Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --HLsZ5Z1opAQvdr2J Content-Type: application/pgp-signature; name="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAlxkTooACgkQ9TYGna5E T6C4fg//RRJh4bdTxluSkHPV9obXmee3fTZWehqaIpScvopl1eqxHXLDy3+48aZs PsSujDPgoXpuVJdfyLE59dQe7w7fnySDbwX6s1LgqE3mkBtPkgVEVoDxWxN3BSK5 U1xSOQrdTJvGBmdGwCdKZimY1/edZHfYq9cktFFPtg65zrtb/Kg47adbB0wuIxEk EukxZNgqgkqBLtGUqE8y8gXyxJ37BfTw1h7Ndgw+M1CkdGXVdzUgb3Y3cyWOEx0f xGv1XrBZhx/8qPxiUe9W5V9uA0mLTpQAbZApuET8Tn+7NlPOcTB4i9ytGxKIwtCf yTfeDtMYWdBxP3IdAWYlHcRIC9qcBbApbqVePNjNPMT+OvrCL8nuLWzvGKgLFAlx EheLiqA4DWRHBzaZ13wLQ8SBGji69VEwvXSfHm+M0dpDaAwDhm1fQkzohDj+uBAd lMZxGygAt6QedqH6ceB87EcN7vF41A8LHr/5bcm20Qn53txAKYLQ7iIIQ24K/iWs cnAZD7iINsgLwr2WNhLJtM/wVKuWdsZVHdWK8XRb/PpGuyLhoQ64OvemLx9GfWsI C41rPj9AWJdgIstFRlvb/x6TD08pPw39g4oUe/mIiWsIPv7LAtrcQCoyB4hFMECw /0SIcwhjO+6rRTF4KXSLX+nqqni1Lp3sKfP0E6lRkv51ll9qK/4= =29qz -----END PGP SIGNATURE----- --HLsZ5Z1opAQvdr2J--