From: Corinna Vinschen <vinschen@redhat.com>
To: Joel Sherrill <joel@rtems.org>
Cc: Dionna Amalie Glaze <dionnaglaze@google.com>,
Newlib <newlib@sourceware.org>,
Yaakov Selkowitz <yselkowi@redhat.com>
Subject: Re: [PATCH] Make st_*tim visible in stat for POSIX.1-2008
Date: Fri, 16 Aug 2019 08:59:00 -0000 [thread overview]
Message-ID: <20190816085904.GS11632@calimero.vinschen.de> (raw)
In-Reply-To: <CAF9ehCUthX+1a7=y6pwh1LgfagDK5bxJGZ2ftyU2Pr+B0ci7LA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
On Aug 15 13:28, Joel Sherrill wrote:
> On Thu, Aug 15, 2019, 10:59 AM Dionna Amalie Glaze via newlib <
> newlib@sourceware.org> wrote:
>
> > You would also need the st_*time defines to be defined if
> > !(defined(__svr4__) && !defined(__PPC__) && !defined(__sun__)) instead of
> > the current defined(__rtems__). Otherwise that seems fine by me.
> >
> > On Thu, Aug 15, 2019 at 3:03 AM Corinna Vinschen <vinschen@redhat.com>
> > wrote:
> >
> > > On Aug 14 12:49, Dionna Amalie Glaze via newlib wrote:
> > > > [...]
> > > I'd like to make the following suggestion, so all targets except svr4
> > etc.
> > > default to the POSIX compatible definition:
> > > [...]
>
> I think this looks good unless there is a concern for small memory targets.
> But this isn't a structure that is forced on every thread so I don't see
> any concern. Make it as standard as possible. :)
Pushed, including the guard fix for the backward compat macros.
HTH,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-08-16 8:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 18:30 Dionna Amalie Glaze via newlib
2019-08-13 18:46 ` Joel Sherrill
2019-08-14 8:41 ` Corinna Vinschen
2019-08-14 18:45 ` Dionna Amalie Glaze via newlib
2019-08-14 18:52 ` Yaakov Selkowitz
2019-08-14 19:06 ` Dionna Amalie Glaze via newlib
2019-08-14 19:25 ` Yaakov Selkowitz
2019-08-14 19:50 ` Dionna Amalie Glaze via newlib
2019-08-15 10:03 ` Corinna Vinschen
2019-08-15 15:59 ` Dionna Amalie Glaze via newlib
2019-08-15 18:29 ` Joel Sherrill
2019-08-16 8:59 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816085904.GS11632@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=dionnaglaze@google.com \
--cc=joel@rtems.org \
--cc=newlib@sourceware.org \
--cc=yselkowi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).