On Aug 15 13:28, Joel Sherrill wrote:
> On Thu, Aug 15, 2019, 10:59 AM Dionna Amalie Glaze via newlib <
> newlib@sourceware.org> wrote:
> 
> > You would also need the st_*time defines to be defined if
> > !(defined(__svr4__) && !defined(__PPC__) && !defined(__sun__)) instead of
> > the current defined(__rtems__). Otherwise that seems fine by me.
> >
> > On Thu, Aug 15, 2019 at 3:03 AM Corinna Vinschen <vinschen@redhat.com>
> > wrote:
> >
> > > On Aug 14 12:49, Dionna Amalie Glaze via newlib wrote:
> > > > [...]
> > > I'd like to make the following suggestion, so all targets except svr4
> > etc.
> > > default to the POSIX compatible definition:
> > > [...]
> 
> I think this looks good unless there is a concern for small memory targets.
> But this isn't a structure that is forced on every thread so I don't see
> any concern. Make it as standard as possible. :)

Pushed, including the guard fix for the backward compat macros.


HTH,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat