From: Corinna Vinschen <vinschen@redhat.com>
To: Joel Sherrill <joel@rtems.org>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: i386 and x86_64 fenv support
Date: Tue, 27 Aug 2019 15:39:00 -0000 [thread overview]
Message-ID: <20190827153922.GZ11632@calimero.vinschen.de> (raw)
In-Reply-To: <CAF9ehCWrHVR3MAojGHEVwLp=44D7F-mE96Frr4fHyzkyPrU8ag@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]
On Aug 27 08:31, Joel Sherrill wrote:
> Hi
>
> Earlier we discussed moving the winsup fenv.h files to newlib. Splitting
> winsup/cygwin/include/fenv.h to create a sys/fenv.h looks easy enough.
> But I have some status and a question after tinkering with this code out
> of tree and compiling with the RTEMS i386 and x86_64
>
> It includes winsup.h and wincap.h but it doesn't need them.
Yeah, that's kind of a boilerplate include in Cygwin code. Just scratch
it, it can't be overly important for the fenv functionality.
> [...]
> There are prototypes for fegetprec() and fesetprec(). I think the
> prototypes need to move to the shared fenv.h and commented
> stubs for the constants needs to be in the shared dummy sys/fenv.h.
> Does this sound right?
As far as I can see, none of Linux or BSD have these functions. It may
be the right thing to do to keep them local to Cygwin since they never
made it into a standard or one of the systems we're interested in here.
Ideally they are never defined in a header, not even on Cygwin. We only
have to keep exporting these symbols in Cygwin for backward compat.
> My remaining issue is that it appears that i386 and x86_64 will need to
> share the same files. Do I just copy the files to both machine directories?
> I don't know if newlib's build infrastructure supports putting it in one
> place and using it in another architecture.
Shouldn't a symlink from x86_64/file to ../i386/file work? git handles
symlinks just fine.
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-08-27 15:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 13:32 Joel Sherrill
2019-08-27 13:37 ` Eric Blake
2019-08-27 13:45 ` Joel Sherrill
2019-08-27 15:39 ` Corinna Vinschen [this message]
2019-08-27 15:46 ` Joel Sherrill
2019-08-27 15:55 ` Corinna Vinschen
2019-08-27 17:11 ` Joseph Myers
2019-08-27 17:30 ` Joel Sherrill
2019-08-27 17:51 ` Howland, Craig D. - US via newlib
2019-08-27 19:48 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827153922.GZ11632@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=joel@rtems.org \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).