From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121287 invoked by alias); 27 Aug 2019 15:55:41 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 121279 invoked by uid 89); 27 Aug 2019 15:55:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Aug 2019 15:55:39 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8058A470C; Tue, 27 Aug 2019 15:55:38 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-116-213.ams2.redhat.com [10.36.116.213]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 263DC60BF7; Tue, 27 Aug 2019 15:55:38 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id C1D79A80431; Tue, 27 Aug 2019 17:55:36 +0200 (CEST) Date: Tue, 27 Aug 2019 15:55:00 -0000 From: Corinna Vinschen To: Joel Sherrill Cc: Newlib Subject: Re: i386 and x86_64 fenv support Message-ID: <20190827155536.GA11632@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: Joel Sherrill , Newlib References: <20190827153922.GZ11632@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+uzL6rrd1EudHdtq" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-SW-Source: 2019/txt/msg00516.txt.bz2 --+uzL6rrd1EudHdtq Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2189 On Aug 27 10:45, Joel Sherrill wrote: > On Tue, Aug 27, 2019 at 10:39 AM Corinna Vinschen w= rote: > > > > On Aug 27 08:31, Joel Sherrill wrote: > > > Hi > > > > > > Earlier we discussed moving the winsup fenv.h files to newlib. Splitt= ing > > > winsup/cygwin/include/fenv.h to create a sys/fenv.h looks easy enough. > > > But I have some status and a question after tinkering with this code = out > > > of tree and compiling with the RTEMS i386 and x86_64 > > > > > > It includes winsup.h and wincap.h but it doesn't need them. > > > > Yeah, that's kind of a boilerplate include in Cygwin code. Just scratch > > it, it can't be overly important for the fenv functionality. > > > > > [...] > > > There are prototypes for fegetprec() and fesetprec(). I think the > > > prototypes need to move to the shared fenv.h and commented > > > stubs for the constants needs to be in the shared dummy sys/fenv.h. > > > Does this sound right? > > > > As far as I can see, none of Linux or BSD have these functions. It may > > be the right thing to do to keep them local to Cygwin since they never > > made it into a standard or one of the systems we're interested in here. > > > > Ideally they are never defined in a header, not even on Cygwin. We only > > have to keep exporting these symbols in Cygwin for backward compat. >=20 > OK. They will disappear from the machine .h files then if that's OK. Sure! > > > My remaining issue is that it appears that i386 and x86_64 will need = to > > > share the same files. Do I just copy the files to both machine direct= ories? > > > I don't know if newlib's build infrastructure supports putting it in = one > > > place and using it in another architecture. > > > > Shouldn't a symlink from x86_64/file to ../i386/file work? git handles > > symlinks just fine. >=20 > Didn't think of that. Sounds good to me. >=20 > How does a patch to winsup get handled? Given the fact I can't build it, > should I just let you handle it after the patch is merged into newlib Just create the patch, I pick up any problems. > I'll keep plugging at this slowly. Reply in PM. Thanks, Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --+uzL6rrd1EudHdtq Content-Type: application/pgp-signature; name="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl1lUngACgkQ9TYGna5E T6C2EQ//am0uJkWKEsmvOPHAdskzk/mFyizNIyOoHyX7GdKGBpHSVMYI3WObweLy 0LCFrWiVIW9Ww4W+0EiaNIeduhsBeM6KwN9u9PQbkbW6KTVHSLan/LJkNZRLIFfH Ev/i5SkYQH7l+HHoRFrz4rVZcVCGRahn4Y0kKnpQDu1ccZJC/NkZOo+Qyla9Tq8N r+uSCnmQNpWbF1g1QzGUxXbgdPH4ARvRI4ZaIzRhOyacc3BDS7eJ04RhLqXlNBxJ jt9haWMkcImhQa7TYIUqPsUCrArbTA/RQIlgZ5LTQJCRCLenmpymoAdBqJPo1QBV XUTyf+naCttFqScoQ4LvqPpFjfbf5R0eKw2E4RowaWaPmGH4EmdoEStSM3XdIDC+ sLuds4tJtl5LfHJWSqPW7MuOc46JzrSN9hVggweRY4uVbrcOWbwsVPEouHLxGNH6 aFEvc6sTtrEKLW4GVuxWPF/dkvpzvm9oSh72JTZwOEzFZGvwJ2a9nC5FKjVcQwO0 TYKXdXkqUJQm024LS8p2gGODTs93yojsP6nnQaj8UX946sg7/3MNVjXJqvckiSyS 6dGdepexLEOlZAIUAkEdGq1vnkM33TN0IFJhRZ0/naxJRUp8QD4LfRr+XNbXQZ4k lBzsDXrIfFsaat4ftEET9V0C8gMlRfD6ej82RZtRlvIMW5w0g5g= =xNLm -----END PGP SIGNATURE----- --+uzL6rrd1EudHdtq--