From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73602 invoked by alias); 18 Nov 2019 10:11:59 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 73592 invoked by uid 89); 18 Nov 2019 10:11:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2 autolearn=ham version=3.3.1 spammy=positions X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Nov 2019 10:11:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574071916; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=HES5RcDa4ZE7obmUVelAQH13P+QrOTgAh5sltkkFFxs=; b=XFiqGyN26n/BIT18VCRA+4UD95q4UyqkcZy1Hndxrz51/dq/fPZl8pQVHChdunXFlXiaSG 1sPIDXLTisMLJKl83uFuFjYBArNHn3iDxJ4j9CZBXqK9NuYNvfJuoHRI8p4xXxLp0G9din 43PcE2dQ9KTRPr0BLwvQMOx+e/cajKQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-426-DvcGk4nmNWy72ouI9nyrpw-1; Mon, 18 Nov 2019 05:11:55 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CE0DF18A4D4E; Mon, 18 Nov 2019 10:11:54 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-117-86.ams2.redhat.com [10.36.117.86]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8ADAE60BE1; Mon, 18 Nov 2019 10:11:54 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 24804A8071F; Mon, 18 Nov 2019 11:11:53 +0100 (CET) Date: Mon, 18 Nov 2019 10:11:00 -0000 From: Corinna Vinschen To: Bastien Bouclet Cc: newlib@sourceware.org Subject: Re: [PATCH] newlib: fix fseek optimization with SEEK_CUR Message-ID: <20191118101153.GB3372@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: Bastien Bouclet , newlib@sourceware.org References: <20191109162804.1905160-1-bastien.bouclet@gmail.com> MIME-Version: 1.0 In-Reply-To: <20191109162804.1905160-1-bastien.bouclet@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Mimecast-Spam-Score: 0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XCKmtPOB2gS6QFgg" Content-Disposition: inline X-SW-Source: 2019/txt/msg00640.txt.bz2 --XCKmtPOB2gS6QFgg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 584 On Nov 9 17:28, Bastien Bouclet wrote: > The call to fflush was invalidating the read buffer, preventing relative > seeks to positions that would have been inside the read buffer from > being optimized. The call to srefill would then re-read mostly the same > data that was initially in the read buffer. > --- > newlib/libc/stdio/fseeko.c | 31 ++++++------------------------- > newlib/libc/stdio64/fseeko64.c | 31 ++++++------------------------- > 2 files changed, 12 insertions(+), 50 deletions(-) Pushed. Thanks, Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --XCKmtPOB2gS6QFgg Content-Type: application/pgp-signature; name="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl3SbmgACgkQ9TYGna5E T6ABZhAAlvFUSNNpd17aYEjyYtjb1W2MnvVnDmU2YxeLBkUxg3QIJlJjPu98mN4Y tP1qVM33tzHVOLAGspVzXPOeG+3cMQG4qSU41Yg1bFRhzIfh7qww25kutHsEq4Cy RjqPi6k+j6eOSm2QpEMyF/NNRUL7ru5RztB07fYRPlcaP6Jn7r73FU42PHwLpfQl XUFbcpvJOWGrIC2nvGVcvK1IDoUCCa7eNSWYck2XwpFm6AFmjBPnz1OtvQjSj9U1 TOm1GWiqBDFmv37EmRfmervjTRbkzEnUpbB1qzgj0svzUBQfZNaPGg8DIxGDgzMW L2gksb64bYcu9z4Ke/wVpga/+RcmQqvIfTTuMDqdapyXxLRtA5B15ToCpSRWsGQl ZQ+aVy2hSDtjc8b73ShRdWLL9DKPxVxuHq0SDKKnxxWuygAA4eJHTTe6eDKjft4B xuAwRUMnT8Y7oGlDDEgVAwTEq+Uw4RYr5EP0MLpv+6i13Ps4ptDlpemill88iDz1 G28bxay+CupWFD3VZt27KXNyOswXnmSK5VAnGZHNftkV8wEAmngbChQIT/yFO8zh Z1gSCvo4M1XhgksmBwKIT9GDFLsHANV06EHpDDL9eLTTb5FtIRABfJorUYvfQhGH 90YEYBmVxWhxTkLyKsqqU0+d6pnFA9Oe65CuSN6ZTBj1T0nY3xA= =DnA4 -----END PGP SIGNATURE----- --XCKmtPOB2gS6QFgg--