From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101994 invoked by alias); 20 Feb 2020 14:10:07 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 101986 invoked by uid 89); 20 Feb 2020 14:10:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*i:sk:CAF9ehC, H*f:sk:nip2ER7, H*i:sk:nip2ER7, H*i:2_yBF X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Feb 2020 14:10:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582207803; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=ago1efZdR/j0RumA7NgOiEAqLUCv1ll9sXY4u2oY9H0=; b=A8isjlbLFqzqxXB0jGUtsoEFUIGMWRlhfPkwk8pvAAJCBqY4naZoAz3hscBxMWvpaXqLan JQ6tIqyfptgQlFUKl4nHt4A4XqbFipyjtdi0CFvhFc/lej5bR/zGeGX/3ZRSjttBdHzwB9 Dy1A6qonwss9F98QGS7aQPMg+cTxQ1c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-78-JJsQK6kbPrmVUWbDwEfMMg-1; Thu, 20 Feb 2020 09:09:55 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 28266802704 for ; Thu, 20 Feb 2020 14:09:55 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-116-53.ams2.redhat.com [10.36.116.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E5E2F92960 for ; Thu, 20 Feb 2020 14:09:54 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 8936BA8086E; Thu, 20 Feb 2020 15:09:53 +0100 (CET) Date: Thu, 20 Feb 2020 14:10:00 -0000 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH v3 2/2] x86_64/i386 fenv: Replace symlink with include fenv_stub.c Message-ID: <20200220140953.GT4092@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <1582121021-30727-1-git-send-email-joel@rtems.org> <1582121021-30727-3-git-send-email-joel@rtems.org> <20200220090036.GP4092@calimero.vinschen.de> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qi3SIpffvxS/TM8d" Content-Disposition: inline X-SW-Source: 2020/txt/msg00100.txt --qi3SIpffvxS/TM8d Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1543 On Feb 20 07:54, Joel Sherrill wrote: > On Thu, Feb 20, 2020 at 3:01 AM Corinna Vinschen > wrote: >=20 > > Hey Joel, > > > > the patch itself is fine, but I'm puzzeling over the commit message. > > > [...] > Yeah. It is an issue with tar. Apparently you can't create symlinks > to non-existent files at least with bsdtar. If the link is in the tar file > before > the real file, it fails to create the file. Maybe GNU tar covers this > up. > [...] > Here is the thread. It is a few messages in before investigation shows it > is a tar file issue. >=20 > https://lists.rtems.org/pipermail/devel/2020-February/057184.html >=20 > The RTEMS ticket is here: >=20 > https://devel.rtems.org/ticket/3868 >=20 > I know this is an odd one. In that case I'd like to change the commit message to something along these lines: --- Having symlinks for these files led to an issue reported to the RTEMS Project that showed up using some tar for native Windows to unpack the newlib sources. It creates symlinks in the tar file as copies of the files the symlinks point to. If the links appear in the tar file before=20 the source exists, it cannot copy the file. The solution in this patch is to convert the files that are symbolic links into simple files which include the file they were linked to. This should be more portable and avoids the symbolinc link problem. --- This doesn't point to MSYS2 or "recet" Windows versions as the culprit. That ok with you? Thanks, Corinna --=20 Corinna Vinschen Cygwin Maintainer Red Hat --qi3SIpffvxS/TM8d Content-Type: application/pgp-signature; name="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl5OkzEACgkQ9TYGna5E T6Dapw//SL/7Pkjy8XQHR55Sylxolv6xLFvapHNWHDt+z0Vnd36J4o+SM5VPrLc5 NaEMecYWCRsqGNqsYEK8xNLCV6tizQ74TiL/uWMv7aZk25gNAxT1MJVn1tXh6Xdi Y3TnYJl1QEwP/k2i2+vVclk3tIoIwyMxIBc0S8z9kofB2LwHmf0AaYurnbebGgj2 oMNoay8CsGxkfGPcNHYvEOrsy+COwjrctLDQyeaTRPD0A4l2rUZzlZ+D1ow4KQJA QGlnx36M6NnxLueZsvXPp6NfmCxOCt56UGQS6G3cAb6/ObM188UBdWgrIqIrNL58 eYkFhK7uMGHJvT4s7emvqy8PNjLVN43Y7st7Mc/JkRRyVk+D0P1jD4Zg2cOjqH7d zdy4dvStKHnqbEFj7wPalG06SRICJd6WgpLgwmrhVtkLd8DL3CRt/1+B6mNDShsK NxXbsouhlWs3tfn1hYD9LT8NvnTdybOhQKkjfUaLIZH5IDv8FDDu4015n2XT3T+y 7uyv119EzRyhl8BO5Zqmogjpbu6exXy1ZYSWCOJP5hD3QOeTX8T0yEabsE+gkAKS EPJdUojca6hxhYz1LvrYQ4xJ+NtFqYGe9Cdm0YDp5IOjUC6Fdq38RV+UJ/+1Hv+T rAR4NLVppxiZYSRA2CpQTw3Cw03YMt8gguIz2F5j+ke/L7gpkIE= =Fwc4 -----END PGP SIGNATURE----- --qi3SIpffvxS/TM8d--