From: Corinna Vinschen <vinschen@redhat.com>
To: Keith Packard <keithp@keithp.com>
Cc: newlib@sourceware.org
Subject: Re: NaN fixes in pow, powf, modf, modff
Date: Thu, 26 Mar 2020 12:42:50 +0100 [thread overview]
Message-ID: <20200326114250.GI3261@calimero.vinschen.de> (raw)
In-Reply-To: <20200326001821.174426-1-keithp@keithp.com>
[-- Attachment #1: Type: text/plain, Size: 624 bytes --]
On Mar 25 17:18, Keith Packard via Newlib wrote:
> The first patch makes modf set *iptr to qnan when provided an snan
> parameter, which wasn't happening on ARM softfp because GCC elided the
> * 1.0 operation.
>
> The second patch cleans up modf/modff by not re-converting the float
> to bits before extracting the sign bit.
>
> The third patch makes pow return qnan instead of 1.0 when the
> parameter is snan.
>
> These functions now match glibc for all of my tests, which were
> derived from the IEEE requirements.
>
Pushed.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-03-26 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 0:18 Keith Packard
2020-03-26 0:18 ` [PATCH 1/3] newlib/libm/common: Fix modf/modff returning snan Keith Packard
2020-03-26 0:18 ` [PATCH 2/3] newlib/libm/common: Don't re-convert float to bits in modf/modff Keith Packard
2020-03-26 0:18 ` [PATCH 3/3] newlib/libm/math: Make pow/powf return qnan for snan arg Keith Packard
2020-03-26 11:42 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326114250.GI3261@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=keithp@keithp.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).