public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Eshan dhawan <eshandhawan51@gmail.com>
Cc: newlib@sourceware.org, jeol@rtems.org
Subject: Re: [PATCH 1/1] fenv support arm
Date: Thu, 2 Jul 2020 13:11:32 +0100	[thread overview]
Message-ID: <20200702121131.GE22681@arm.com> (raw)
In-Reply-To: <20200603174509.18606-2-eshandhawan51@gmail.com>

The 06/03/2020 23:15, Eshan dhawan via Newlib wrote:
> --- /dev/null
> +++ b/newlib/libc/machine/arm/sys/fenv.h
...
> +#ifndef __ARM_PCS_VFP
> +
> +int feclearexcept(int excepts);
> +int fegetexceptflag(fexcept_t *flagp, int excepts);
> +int fesetexceptflag(const fexcept_t *flagp, int excepts);
> +int feraiseexcept(int excepts);
> +int fetestexcept(int excepts);
> +int fegetround(void);
> +int fesetround(int round);
> +int fegetenv(fenv_t *envp);
> +int feholdexcept(fenv_t *envp);
> +int fesetenv(const fenv_t *envp);
> +int feupdateenv(const fenv_t *envp);
> +#if __BSD_VISIBLE
> +int feenableexcept(int __mask);
> +int fedisableexcept(int __mask);
> +int fegetexcept(void);
> +#endif /* __BSD_VISIBLE */
> +
> +#endif	/* __ARM_PCS_VFP */

why are these declarations conditional?

i get build failures e.g. in libgfortran
because configure detects the availability
of feenableexcept in libm.a so it starts
using it but then fenv.h does not have the
declaration so compilation fails.

it seems there is vfp code for all this
so why are the declarations removed?


  reply	other threads:[~2020-07-02 12:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 17:45 [PATCH 0/1] Add fenv support for ARM Eshan dhawan
2020-06-03 17:45 ` [PATCH 1/1] fenv support arm Eshan dhawan
2020-07-02 12:11   ` Szabolcs Nagy [this message]
2020-07-02 15:48     ` Joel Sherrill
2020-07-02 22:33       ` Joel Sherrill
2020-07-03  9:14         ` Szabolcs Nagy
2020-07-03 13:12           ` Joel Sherrill
2020-06-10  1:15 ` [PATCH 0/1] Add fenv support for ARM Jeff Johnston
2020-06-10 17:31   ` Sebastian Huber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200702121131.GE22681@arm.com \
    --to=szabolcs.nagy@arm.com \
    --cc=eshandhawan51@gmail.com \
    --cc=jeol@rtems.org \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).