From: Keith Packard <keithp@keithp.com>
To: newlib@sourceware.org
Subject: [PATCH 1/4] libc/iconv: Detect CES handler loading failure
Date: Thu, 9 Jul 2020 16:58:45 -0700 [thread overview]
Message-ID: <20200709235848.3496713-1-keithp@keithp.com> (raw)
Fix the code checking for character set loading failure so that
it checks the return value from the init function.
Signed-off-by: Keith Packard <keithp@keithp.com>
---
newlib/libc/iconv/ces/euc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/newlib/libc/iconv/ces/euc.c b/newlib/libc/iconv/ces/euc.c
index 29d36f941..ebd7091b0 100644
--- a/newlib/libc/iconv/ces/euc.c
+++ b/newlib/libc/iconv/ces/euc.c
@@ -306,7 +306,7 @@ ok:
data->data[i] = _iconv_to_ucs_ces_handlers_table.init (
rptr,
data->desc[i].csname);
- if (data->data == NULL)
+ if (data->data[i] == NULL)
goto error;
}
--
2.27.0
next reply other threads:[~2020-07-09 23:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 23:58 Keith Packard [this message]
2020-07-09 23:58 ` [PATCH 2/4] libc/iconv: Remove unneeded pointer var for _iconv_aliases Keith Packard
2020-07-09 23:58 ` [PATCH 3/4] libc/iconv: find_alias was mis-computing remaining alias table length Keith Packard
2020-07-09 23:58 ` [PATCH 4/4] testsuite: Fix iconv tests to use new encoding config defines Keith Packard
2020-07-10 10:05 ` [PATCH 1/4] libc/iconv: Detect CES handler loading failure Corinna Vinschen
2020-07-11 0:26 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709235848.3496713-1-keithp@keithp.com \
--to=keithp@keithp.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).