From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 03F70386F447 for ; Fri, 10 Jul 2020 10:05:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 03F70386F447 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-6-bhYGkTsmNQ6ICSU5yTIJgQ-1; Fri, 10 Jul 2020 06:05:11 -0400 X-MC-Unique: bhYGkTsmNQ6ICSU5yTIJgQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 30E88107ACCA; Fri, 10 Jul 2020 10:05:10 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-53.ams2.redhat.com [10.36.112.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 041DA10016DA; Fri, 10 Jul 2020 10:05:09 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 3BD21A80B92; Fri, 10 Jul 2020 12:05:08 +0200 (CEST) Date: Fri, 10 Jul 2020 12:05:08 +0200 From: Corinna Vinschen To: Keith Packard Cc: newlib@sourceware.org Subject: Re: [PATCH 1/4] libc/iconv: Detect CES handler loading failure Message-ID: <20200710100508.GF514059@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: Keith Packard , newlib@sourceware.org References: <20200709235848.3496713-1-keithp@keithp.com> MIME-Version: 1.0 In-Reply-To: <20200709235848.3496713-1-keithp@keithp.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2020 10:05:14 -0000 On Jul 9 16:58, Keith Packard via Newlib wrote: > Fix the code checking for character set loading failure so that > it checks the return value from the init function. > > Signed-off-by: Keith Packard > --- > newlib/libc/iconv/ces/euc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/newlib/libc/iconv/ces/euc.c b/newlib/libc/iconv/ces/euc.c > index 29d36f941..ebd7091b0 100644 > --- a/newlib/libc/iconv/ces/euc.c > +++ b/newlib/libc/iconv/ces/euc.c > @@ -306,7 +306,7 @@ ok: > data->data[i] = _iconv_to_ucs_ces_handlers_table.init ( > rptr, > data->desc[i].csname); > - if (data->data == NULL) > + if (data->data[i] == NULL) > goto error; > } > > -- > 2.27.0 Pushed. Just, please create patchsets with cover letter. It's better for replies in terms of the entire patchset vs. replies to a single patch. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer Red Hat