From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id BE0263846416 for ; Mon, 27 Jul 2020 08:07:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BE0263846416 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-184-pg6LvpVTMUasEJ7-gVYC9w-1; Mon, 27 Jul 2020 04:07:31 -0400 X-MC-Unique: pg6LvpVTMUasEJ7-gVYC9w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D8FFC100AA22 for ; Mon, 27 Jul 2020 08:07:30 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-68.ams2.redhat.com [10.36.112.68]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ACA7410023A7 for ; Mon, 27 Jul 2020 08:07:30 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 467EDA8096F; Mon, 27 Jul 2020 10:07:29 +0200 (CEST) Date: Mon, 27 Jul 2020 10:07:29 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 0/2] Fix fenv support for ARM Message-ID: <20200727080729.GC4206@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20200719110112.14255-1-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2020 08:07:35 -0000 On Jul 23 07:13, Sebastian Huber wrote: > On 19/07/2020 13:01, Sebastian Huber wrote: > > > This patch set addresses some issues which popped up while building Newlib for > > ARM with GCC 10 which enables -fno-common by default. > > > > Eshan dhawan (1): > > arm: Fix fenv support > > > > Sebastian Huber (1): > > arm: Remove superfluous fenv stub files > > I just noticed that the stub files I removed are not superfluous. Its seems > they are necessary to somehow overwrite the default implementations in: > > newlib/libm/fenv > > There seems to be some build system magic involved here. I guess we have to > split up fenv.c and move all the functions to individual files matching the > ones in newlib/libm/fenv? Splitting is probably better. When you created and tested a new patchset, feel free to push it. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer Red Hat