From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id E3F2E3858D37 for ; Mon, 17 Aug 2020 09:22:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E3F2E3858D37 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-376-okeVM6WyOcuHSjIJQpS1mQ-1; Mon, 17 Aug 2020 05:22:47 -0400 X-MC-Unique: okeVM6WyOcuHSjIJQpS1mQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C58271007469; Mon, 17 Aug 2020 09:22:46 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-9.ams2.redhat.com [10.36.112.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 78385614F9; Mon, 17 Aug 2020 09:22:46 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id F3169A806A2; Mon, 17 Aug 2020 11:22:44 +0200 (CEST) Date: Mon, 17 Aug 2020 11:22:44 +0200 From: Corinna Vinschen To: Joel Sherrill Cc: Newlib , Eshan dhawan , joel@rtems.com Subject: Re: [PATCH] Removed Soft float from MIPS Message-ID: <20200817092244.GB3272@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: Joel Sherrill , Newlib , Eshan dhawan , joel@rtems.com References: <20200812213535.25430-1-eshandhawan51@gmail.com> <20200813081945.GW53219@calimero.vinschen.de> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2020 09:22:53 -0000 On Aug 13 08:10, Joel Sherrill wrote: > On Thu, Aug 13, 2020 at 3:19 AM Corinna Vinschen via Newlib < > newlib@sourceware.org> wrote: > > > On Aug 13 03:05, Eshan dhawan via Newlib wrote: > > > This Patch removes Soft Float code from MIPS. > > > Instead It adds the soft float code from RISCV > > > > Why, and why is that the right thing to do? > > > > The code came from FreeBSD and assumes the FreeBSD softfp > implementation not the one with GCC. That was an overlooked and > fixed in the other fenv code already. > > --joel That information belongs into the commit message. Corinna