From: Keith Packard <keithp@keithp.com>
To: newlib@sourceware.org
Subject: [PATCH 5/6] libc/stdlib: Clean up clang warnings
Date: Thu, 20 Aug 2020 15:14:48 -0700 [thread overview]
Message-ID: <20200820221449.686006-6-keithp@keithp.com> (raw)
In-Reply-To: <20200820221449.686006-1-keithp@keithp.com>
Eliminate hand-written strcpy in setenv.
Signed-off-by: Keith Packard <keithp@keithp.com>
---
newlib/libc/stdlib/setenv_r.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/newlib/libc/stdlib/setenv_r.c b/newlib/libc/stdlib/setenv_r.c
index 84d87a6ed..cdfa04f33 100644
--- a/newlib/libc/stdlib/setenv_r.c
+++ b/newlib/libc/stdlib/setenv_r.c
@@ -75,7 +75,7 @@ _setenv_r (struct _reent *reent_ptr,
}
if (strlen (C) >= l_value)
{ /* old larger; copy over */
- while ((*C++ = *value++) != 0);
+ strcpy(C, value);
ENV_UNLOCK;
return 0;
}
--
2.28.0
next prev parent reply other threads:[~2020-08-20 22:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 22:14 [PATCH 0/6] Fixes inspired by building with clang Keith Packard
2020-08-20 22:14 ` [PATCH 1/6] libm/stdlib: Recover from realloc failure when shrinking Keith Packard
2020-08-20 22:14 ` [PATCH 2/6] libc/iconv: Check ces handlers table value in euc_from_ucs_init Keith Packard
2020-08-20 22:14 ` [PATCH 3/6] Avoid implicit floating point conversions Keith Packard
2020-08-20 22:43 ` Joseph Myers
[not found] ` <SN5P110MB03830A3D8272D82A089605659A5A0@SN5P110MB0383.NAMP110.PROD.OUTLOOK.COM>
2020-08-20 23:03 ` Fw: " C Howland
2020-08-21 0:01 ` Keith Packard
2020-08-20 22:14 ` [PATCH 4/6] libc/stdlib: Undefined shift negative value in a64l Keith Packard
2020-08-20 22:14 ` Keith Packard [this message]
2020-08-20 22:14 ` [PATCH 6/6] libc/stdio: Conditionally declare vars for _FSEEK_OPTIMIZATION Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820221449.686006-6-keithp@keithp.com \
--to=keithp@keithp.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).