From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id B9E013858D37 for ; Wed, 26 Aug 2020 07:50:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B9E013858D37 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-322-7uN_A4_eOQ2FkUqQnH3UzQ-1; Wed, 26 Aug 2020 03:50:38 -0400 X-MC-Unique: 7uN_A4_eOQ2FkUqQnH3UzQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3FC93107464A for ; Wed, 26 Aug 2020 07:50:37 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-113-99.ams2.redhat.com [10.36.113.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 119265D9E4 for ; Wed, 26 Aug 2020 07:50:37 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 92747A83A75; Wed, 26 Aug 2020 09:50:35 +0200 (CEST) Date: Wed, 26 Aug 2020 09:50:35 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] doc: Various fixes to makedocbook for python3.8 Message-ID: <20200826075035.GL3272@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20200822184520.57006-1-jon.turney@dronecode.org.uk> <20200824100115.GC3272@calimero.vinschen.de> <5718ea21-5420-7401-3a79-4122cfa0e723@dronecode.org.uk> MIME-Version: 1.0 In-Reply-To: <5718ea21-5420-7401-3a79-4122cfa0e723@dronecode.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2020 07:50:43 -0000 On Aug 25 20:45, Jon Turney wrote: > On 24/08/2020 11:01, Corinna Vinschen via Newlib wrote: > > On Aug 23 20:41, Jon Turney wrote: > > > On 23/08/2020 16:23, Ken Brown wrote: > > > > On 8/22/2020 2:45 PM, Jon Turney wrote: > > > > > --- > > > > >   newlib/doc/makedocbook.py | 8 +++++--- > > > > >   1 file changed, 5 insertions(+), 3 deletions(-) > > > > > > > > > > diff --git a/newlib/doc/makedocbook.py b/newlib/doc/makedocbook.py > > > > > index 92d0f279d..3fab26f1a 100755 > > > > > --- a/newlib/doc/makedocbook.py > > > > > +++ b/newlib/doc/makedocbook.py > > > [...] > > > > Would it make sense to also change the shebang line so that > > > > makedocbook.py uses python3?  Currently the build of Cygwin on Fedora > > > > uses python3, but the build of Cygwin on Cygwin uses python2.  This is > > > > of no great importance, but a recent IRC discussion shows that it can be > > > > confusing. > > > > > > Yeah, I guess that would make some sense, given that python2 is now EOL. > > > > > > Otoh, making it gratuitously not work with python2 seems a bit harsh. > > > > > > On the gripping hand, reading PEP 0394, I see it doesn't actually require > > > that 'python' exist at all, so I guess changing the shebang as you suggest > > > is the right thing to do. > > > > With this change, please push. > > Testing on system where '/usr/bi/python' doesn't exist, there's also another > script which I neglected to update. > > Patch attached. Go for it. Thanks, Corinna