From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 45F32386F427 for ; Wed, 26 Aug 2020 18:20:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 45F32386F427 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-298-XbVz2aItNnO4F6nAKK0Zcw-1; Wed, 26 Aug 2020 14:20:49 -0400 X-MC-Unique: XbVz2aItNnO4F6nAKK0Zcw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 49F18F6C01 for ; Wed, 26 Aug 2020 18:20:48 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-113-99.ams2.redhat.com [10.36.113.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1BB4D19C58 for ; Wed, 26 Aug 2020 18:20:48 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 9F369A81007; Wed, 26 Aug 2020 20:20:46 +0200 (CEST) Date: Wed, 26 Aug 2020 20:20:46 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 2/3] libm: Remove __ieee754_gamma_r variants Message-ID: <20200826182046.GR3272@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20200826170357.2551683-1-keithp@keithp.com> <20200826170357.2551683-3-keithp@keithp.com> MIME-Version: 1.0 In-Reply-To: <20200826170357.2551683-3-keithp@keithp.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2020 18:20:53 -0000 Hi Keith, On Aug 26 10:03, Keith Packard via Newlib wrote: > Gamma should consume the sign reported by lgamma internally instead of > providing it back to the application. This removes the need to have _r > variants as there is no longer any re-entrancy issues with the API. You can't do that. gamma_r/gammaf_r/lgamma_r/lgammaf_r are BSD functions. They have been exported by Cygwin since 2001. The entry points need to be kept available with unchanged semantics. Corinna