From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 393B0386F42A for ; Fri, 28 Aug 2020 08:34:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 393B0386F42A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-294-NxdRL0OYPPefCMWgiPHdwQ-1; Fri, 28 Aug 2020 04:34:50 -0400 X-MC-Unique: NxdRL0OYPPefCMWgiPHdwQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 667C7802B7D for ; Fri, 28 Aug 2020 08:34:49 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-113-99.ams2.redhat.com [10.36.113.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 383C1757D1 for ; Fri, 28 Aug 2020 08:34:49 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id D164BA83A7B; Fri, 28 Aug 2020 10:34:47 +0200 (CEST) Date: Fri, 28 Aug 2020 10:34:47 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 2/3] libm: Remove __ieee754_gamma_r variants Message-ID: <20200828083447.GE3272@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20200826170357.2551683-1-keithp@keithp.com> <20200826170357.2551683-3-keithp@keithp.com> <20200826182046.GR3272@calimero.vinschen.de> <87v9h5dy00.fsf@keithp.com> <20200827072411.GT3272@calimero.vinschen.de> <87pn7cdnns.fsf@keithp.com> <20200828081951.GD3272@calimero.vinschen.de> MIME-Version: 1.0 In-Reply-To: <20200828081951.GD3272@calimero.vinschen.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2020 08:34:53 -0000 On Aug 28 10:19, Corinna Vinschen via Newlib wrote: > On Aug 27 10:05, Keith Packard via Newlib wrote: > > Corinna Vinschen via Newlib writes: > > > > > Nevertheless, the symbols have to be exported for backward compatibility. > > > So you're saying aliasing gamma_r to lgamma_r and gammaf_r to lgammaf_r > > > in the DLLs export table would be sufficient? > > > > It depends if you want the pre-2002 functionality or the post-2002 > > functionality. > > The important point is that gamma_r and gammaf_r are exported by Cygwin > and must be kept available, otherwise building the DLL fails. If they > returned the wrong vaslue, that's a bug and needs fixing. > > Whether gamma_r and gammaf_r are still functions on their own, or if > they are just defined as aliases to lgamma_r and lgammaf_r in > winsup/cygwin/common.din, as in > > gamma_r = lgamma_r NOSIGFE > gammaf_r = lgammaf_r NOSIGFE > > is up to you. On second thought, given gamma_r and gammaf_r are BSD functions, it might be a good idea to keep the wrapper functions for other targets as well. Any input from the RTEMS guys, perhaps? Thanks, Corinna