From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 9719C385781D for ; Fri, 4 Sep 2020 13:03:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9719C385781D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-530-Qn8oTK63NvC6_QYl0ebtvg-1; Fri, 04 Sep 2020 09:03:56 -0400 X-MC-Unique: Qn8oTK63NvC6_QYl0ebtvg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DFBEA80F057 for ; Fri, 4 Sep 2020 13:03:55 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-118-162.rdu2.redhat.com [10.10.118.162]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5429A7EEBB for ; Fri, 4 Sep 2020 13:03:54 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 9476FA83A87; Fri, 4 Sep 2020 15:03:52 +0200 (CEST) Date: Fri, 4 Sep 2020 15:03:52 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 2/3] libm: Remove __ieee754_gamma_r variants Message-ID: <20200904130352.GS4127@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <871rjlcsy0.fsf@keithp.com> <20200902080345.GF4127@calimero.vinschen.de> <87lfhrap9h.fsf@keithp.com> <20200903080441.GM4127@calimero.vinschen.de> <79b6e41b-5697-6c0b-5d11-59407b1e0ec8@SystematicSw.ab.ca> <87mu268sdv.fsf@keithp.com> <7a4384ad-b698-84bf-a0bb-ef796dffdb99@SystematicSw.ab.ca> <87k0xa8l5v.fsf@keithp.com> <87h7se8gqp.fsf@keithp.com> MIME-Version: 1.0 In-Reply-To: <87h7se8gqp.fsf@keithp.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Sep 2020 13:03:59 -0000 On Sep 3 18:37, Keith Packard via Newlib wrote: > Brian Inglis writes: > > > gamma > > gamma_r > > gammaf > > gammaf_r > > lgamma > > lgamma_r > > lgammaf > > lgammaf_r > > lgammal > > lgammal_r > > tgamma > > tgammaf > > tgammal > > > > so these may be the official ABI, and the others don't matter? > > I would hope so -- the __ieee754 functions seem mostly like an internal > implementation detail, but it's hard to know. > > If this is true, then I think the patch as posted should be what we want. The ieee functions can go away. The symbols from cygwin1.dll don't count, the ones exported from /usr/lib/libcygwin.a do. These are defined in winsup/cygwin/{common.din,i686.din,x86_64.din} Corinna