From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id E215D398680B for ; Fri, 4 Sep 2020 13:19:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E215D398680B Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-531-GO-Vd6TgMD2OIsEdJTieSg-1; Fri, 04 Sep 2020 09:19:45 -0400 X-MC-Unique: GO-Vd6TgMD2OIsEdJTieSg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8FC9010BBEC2 for ; Fri, 4 Sep 2020 13:19:44 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-118-162.rdu2.redhat.com [10.10.118.162]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F6E85C22B for ; Fri, 4 Sep 2020 13:19:44 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 85D10A83A8D; Fri, 4 Sep 2020 15:19:42 +0200 (CEST) Date: Fri, 4 Sep 2020 15:19:42 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] libm: Fix 'gamma' and 'gammaf' functions. Clean up other gamma code. Message-ID: <20200904131942.GV4127@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20200903212246.2121028-1-keithp@keithp.com> MIME-Version: 1.0 In-Reply-To: <20200903212246.2121028-1-keithp@keithp.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Sep 2020 13:19:48 -0000 On Sep 3 14:22, Keith Packard via Newlib wrote: > The current gamma, gamma_r, gammaf and gammaf_r functions return > |Γ(x)| instead of ln(|Γ(x)|) due to a change made back in 2002 to the This is kind of funny right now, but I can't push this change. The repo integrity checks (same as for binutils/gdb repo btw) complain about Γ: remote: *** Invalid revision history for commit dcac20a59d62c81c37250da8a35c5d81a5fd3ccf: remote: *** It contains characters not in the ISO-8859-15 charset. remote: *** remote: *** Below is the first line where this was detected (line 4): remote: *** | |Γ(x)| instead of ln(|Γ(x)|) due to a change made back in 2002 to the remote: *** ^ remote: *** | remote: *** remote: *** Please amend the commit's revision history to remove it remote: *** and try again. remote: error: hook declined to update refs/heads/master Apart from the fact that not allowing any UTF-8 char is a bit awkward these days... how would you like the above to be expressed under these rules? Thanks, Corinna