From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by sourceware.org (Postfix) with ESMTPS id 3BDD2398B178 for ; Thu, 1 Oct 2020 14:19:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3BDD2398B178 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 091EHAX2007201 for ; Thu, 1 Oct 2020 16:19:11 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 33svhewv6a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 01 Oct 2020 16:19:11 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 97CD410002A for ; Thu, 1 Oct 2020 16:19:10 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag1node1.st.com [10.75.127.1]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 244F32B1510 for ; Thu, 1 Oct 2020 16:19:10 +0200 (CEST) Received: from localhost (10.75.127.45) by SFHDAG1NODE1.st.com (10.75.127.1) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 1 Oct 2020 16:19:09 +0200 From: =?UTF-8?q?Torbj=C3=B6rn=20SVENSSON?= To: Subject: [PATCH 0/3] libc: Comply with the libstdc++ test case names.cc Date: Thu, 1 Oct 2020 16:17:50 +0200 Message-ID: <20201001141753.6657-1-torbjorn.svensson@st.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG7NODE1.st.com (10.75.127.19) To SFHDAG1NODE1.st.com (10.75.127.1) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-01_04:2020-10-01, 2020-10-01 signatures=0 X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2020 14:19:17 -0000 As discussed in GCC bug 97088 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in prototypes of library functions should use reserved names, or no name at all. It's somewhat unclear how to handle members in structs, but as the __tzrule_struct is an internal newlib struct, I don't see any point in not trying to comply here too. Without the patches, you will get errors like: In file included from /work/build-native/gcc-final/arm-none-eabi/thumb/v6-m/nofp/libstdc++-v3/include/ctime:42, from /work/build-native/gcc-final/arm-none-eabi/thumb/v6-m/nofp/libstdc++-v3/include/arm-none-eabi/bits/stdc++.h:49, from /work/src/gcc/libstdc++-v3/testsuite/17_intro/names.cc:199: /work/install-native/arm-none-eabi/include/time.h:110: error: expected unqualified-id before ';' token /work/install-native/arm-none-eabi/include/time.h:110: error: expected ')' before ';' token /work/src/gcc/libstdc++-v3/testsuite/17_intro/names.cc:55: note: to match this '(' In file included from /work/build-native/gcc-final/arm-none-eabi/thumb/v6-m/nofp/libstdc++-v3/include/cwchar:44, from /work/build-native/gcc-final/arm-none-eabi/thumb/v6-m/nofp/libstdc++-v3/include/arm-none-eabi/bits/stdc++.h:50, from /work/src/gcc/libstdc++-v3/testsuite/17_intro/names.cc:199: /work/install-native/arm-none-eabi/include/wchar.h:251: error: expected ')' before ';' token /work/install-native/arm-none-eabi/include/wchar.h:252: error: expected ')' before ';' token In file included from /work/build-native/gcc-final/arm-none-eabi/thumb/v6-m/nofp/libstdc++-v3/include/cinttypes:46, from /work/build-native/gcc-final/arm-none-eabi/thumb/v6-m/nofp/libstdc++-v3/include/arm-none-eabi/bits/stdc++.h:56, from /work/src/gcc/libstdc++-v3/testsuite/17_intro/names.cc:199: /work/install-native/arm-none-eabi/include/inttypes.h:323: error: expected ')' before ';' token I'd need someone to help me push the patches since I have no commit access. Torbjörn SVENSSON (3): libc/include/inttypes.h: Remove parameter name libc/include/wchar.h: Remove parameter name libc: Replace one letter member names in __tzrule_struct newlib/libc/include/inttypes.h | 2 +- newlib/libc/include/time.h | 8 ++++---- newlib/libc/include/wchar.h | 4 ++-- newlib/libc/time/tzcalc_limits.c | 14 +++++++------- newlib/libc/time/tzset_r.c | 22 +++++++++++----------- 5 files changed, 25 insertions(+), 25 deletions(-) -- 2.18.0