From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 213BA3857802 for ; Thu, 15 Oct 2020 17:15:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 213BA3857802 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-577-cK7bBTPON2mVluNO5cLMEQ-1; Thu, 15 Oct 2020 13:15:34 -0400 X-MC-Unique: cK7bBTPON2mVluNO5cLMEQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3A89D1084C82 for ; Thu, 15 Oct 2020 17:15:33 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-114-205.ams2.redhat.com [10.36.114.205]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C9C860CD0; Thu, 15 Oct 2020 17:15:33 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 9A8C7A82BC2; Thu, 15 Oct 2020 19:15:31 +0200 (CEST) Date: Thu, 15 Oct 2020 19:15:31 +0200 From: Corinna Vinschen To: Jeff Johnston Cc: newlib@sourceware.org Subject: Re: [PATCH v2] libc/time: Move internal newlib tz-structs to local.h Message-ID: <20201015171531.GB582570@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: Jeff Johnston , newlib@sourceware.org References: <20201005125011.28344-1-torbjorn.svensson@st.com> <20201015102139.GI26704@calimero.vinschen.de> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2020 17:15:37 -0000 On Oct 15 13:09, Jeff Johnston via Newlib wrote: > I also like this solution, but again as I mentioned earlier, it technically > requires a major release bump due to the removal of API from time.h and > would be best > to wait until we have something else warranting a major release bump. > > That said, what do you think Corinna? Oops, time warp! Sorry, but I already pushed this. >From my POV, these *are* internal structs and functions, so, technically, they are *not* official API and consequentially nobody has the right to expect them in an official header. For me the only problem is that the members are not underscored and may produce problems. Corinna > > -- Jeff J. > > On Thu, Oct 15, 2020 at 12:47 PM Torbjorn SVENSSON via Newlib < > newlib@sourceware.org> wrote: > > > Hello Corinna, > > > > Thanks for the feedback and I hope that you had a nice vacation! > > > > I haven't run tests with your patch applied, but just reading it should be > > fine. > > I see no reason why "sys/_tz_structs.h" would be included from > > "bits/stdc++.h", and it is this particular include chain that is causing > > the problems in the libstdc ++ test suite, so if it works for Cygwin, I'd > > say go for it! > > > > Kind regards, > > Torbjörn > > > > -----Original Message----- > > From: Corinna Vinschen > > Sent: den 15 oktober 2020 12:22 > > To: Torbjorn SVENSSON > > Cc: newlib@sourceware.org > > Subject: Re: [PATCH v2] libc/time: Move internal newlib tz-structs to > > local.h > > > > On Oct 15 06:52, Torbjorn SVENSSON via Newlib wrote: > > > Ping! > > > > Due to vacation I only just checked now. The patch breaks the Cygwin > > build. Especially __tzinfo_type has to be exposed from a public header > > in newlib. > > > > So what about the attached patch instead? > > > > > > Corinna > >