public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: newlib@sourceware.org
Subject: [PATCH 5/5] amd64: prevent KCSan false positives on LAPIC mapping
Date: Mon, 19 Oct 2020 17:55:37 +0200	[thread overview]
Message-ID: <20201019155537.15290-6-sebastian.huber@embedded-brains.de> (raw)
In-Reply-To: <20201019155537.15290-1-sebastian.huber@embedded-brains.de>

From: jah <jah@FreeBSD.org>

For configurations without x2APIC support (guests, older hardware), the global
LAPIC MMIO mapping will trigger false-positive KCSan reports as it will appear
that multiple CPUs are concurrently reading and writing the same address.
This isn't actually true, as the underlying physical access will be performed
on the local CPU's APIC. Additionally, because LAPIC access can happen during
event timer configuration, the resulting KCSan printf can produce a panic due
to attempted recursion on event timer resources.

Add a __nosanitizethread preprocessor define to prevent the compiler from
inserting TSan hooks, and apply it to the x86 LAPIC accessors.

PR:		249149
Reported by:	gbe
Reviewed by:	andrew, kib
Tested by:	gbe
Differential Revision:	https://reviews.freebsd.org/D26354
---
 newlib/libc/include/sys/cdefs.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/newlib/libc/include/sys/cdefs.h b/newlib/libc/include/sys/cdefs.h
index 1be994ffd..da7290921 100644
--- a/newlib/libc/include/sys/cdefs.h
+++ b/newlib/libc/include/sys/cdefs.h
@@ -716,8 +716,10 @@
  */
 #if __has_attribute(no_sanitize) && defined(__clang__)
 #define __nosanitizeaddress	__attribute__((no_sanitize("address")))
+#define __nosanitizethread	__attribute__((no_sanitize("thread")))
 #else
 #define __nosanitizeaddress
+#define __nosanitizethread
 #endif
 
 /* Guard variables and structure members by lock. */
-- 
2.26.2


  parent reply	other threads:[~2020-10-19 15:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 15:55 [PATCH 0/5] Synchronize <sys/cdefs.h> and <stdatomic.h> with FreeBSD Sebastian Huber
2020-10-19 15:55 ` [PATCH 1/5] Make the system C11 atomics headers fully compatible with external GCC Sebastian Huber
2020-10-19 15:55 ` [PATCH 2/5] Don't sanitize linker_set Sebastian Huber
2020-10-19 15:55 ` [PATCH 3/5] gcc: quiet Wattribute for no_sanitize("address") Sebastian Huber
2020-10-19 15:55 ` [PATCH 4/5] sys: clean up empty lines in .c and .h files Sebastian Huber
2020-10-19 15:55 ` Sebastian Huber [this message]
2020-10-26  9:51 ` [PATCH 0/5] Synchronize <sys/cdefs.h> and <stdatomic.h> with FreeBSD Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201019155537.15290-6-sebastian.huber@embedded-brains.de \
    --to=sebastian.huber@embedded-brains.de \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).