From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id BF00F387087F for ; Mon, 26 Oct 2020 10:53:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BF00F387087F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-445-cRGaEVYNObGMJm9Q5QdIjQ-1; Mon, 26 Oct 2020 06:53:54 -0400 X-MC-Unique: cRGaEVYNObGMJm9Q5QdIjQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 901C5425F3 for ; Mon, 26 Oct 2020 10:53:53 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-113-110.ams2.redhat.com [10.36.113.110]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 629CA10013D0 for ; Mon, 26 Oct 2020 10:53:53 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id E64F9A81039; Mon, 26 Oct 2020 11:53:51 +0100 (CET) Date: Mon, 26 Oct 2020 11:53:51 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: RFC: Changing daddr_t to 64 bits Message-ID: <20201026105351.GC5492@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20201026095752.GB5492@calimero.vinschen.de> MIME-Version: 1.0 In-Reply-To: <20201026095752.GB5492@calimero.vinschen.de> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2020 10:53:58 -0000 On Oct 26 10:57, Corinna Vinschen via Newlib wrote: > On Oct 25 16:43, Joel Sherrill wrote: > > Hi > > > > The type daddr_t is defined to be long but per some IBM documentation, it > > is "used for disk addresses, except in i-nodes on disk. The > > */usr/include/sys/filsys.h* file format describes the format of disk > > addresses used in i-nodes." > > > > RTEMS has this in our BSD derived code and 32-bits is too small for disk > > addresses. We need it to be 64-bits at least for us. > > > > Can I change it to be 64-bits for all targets? > > I don't think so. The existing non-RTEMS definitions should stay > untouched for backward compat. Noticable is phoenix, which defines > __daddr_t explicitely as __uint32_t. > > AFAICS, RTEMS defines __daddr_t not at all. Just define __daddr_t in > newlib/libc/sys/linux/sys/types.h should fix this up for you. ^^^^^ Probably better newlib/libc/sys/rtems/include/sys/types.h Sorry, Corinna