From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 0DFC73854810 for ; Thu, 29 Oct 2020 08:41:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0DFC73854810 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-557-u3agq2p3NrK1DF4_hYLj5g-1; Thu, 29 Oct 2020 04:41:44 -0400 X-MC-Unique: u3agq2p3NrK1DF4_hYLj5g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 725A0805F02; Thu, 29 Oct 2020 08:41:43 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-113-110.ams2.redhat.com [10.36.113.110]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4308C5C1D0; Thu, 29 Oct 2020 08:41:43 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id DA0ABA81037; Thu, 29 Oct 2020 09:41:41 +0100 (CET) Date: Thu, 29 Oct 2020 09:41:41 +0100 From: Corinna Vinschen To: Kito Cheng Cc: newlib@sourceware.org, kito.cheng@gmail.com Subject: Re: [PATCH 1/2] RISC-V: NaN should return 0 for finite[f] Message-ID: <20201029084141.GT5492@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: Kito Cheng , newlib@sourceware.org, kito.cheng@gmail.com References: <20201028154127.41565-1-kito.cheng@sifive.com> MIME-Version: 1.0 In-Reply-To: <20201028154127.41565-1-kito.cheng@sifive.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2020 08:41:48 -0000 On Oct 28 23:41, Kito Cheng wrote: > --- > newlib/libm/machine/riscv/s_finite.c | 2 +- > newlib/libm/machine/riscv/sf_finite.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/newlib/libm/machine/riscv/s_finite.c b/newlib/libm/machine/riscv/s_finite.c > index f5336e5dc..1f1f2244d 100644 > --- a/newlib/libm/machine/riscv/s_finite.c > +++ b/newlib/libm/machine/riscv/s_finite.c > @@ -44,7 +44,7 @@ > int finite(double x) > { > long fclass = _fclass_d (x); > - return (fclass & FCLASS_INF) == 0; > + return (fclass & (FCLASS_INF | FCLASS_NAN)) == 0; > } > #else > #include "../../common/s_finite.c" > diff --git a/newlib/libm/machine/riscv/sf_finite.c b/newlib/libm/machine/riscv/sf_finite.c > index f1cf5c6ce..a17b0fa36 100644 > --- a/newlib/libm/machine/riscv/sf_finite.c > +++ b/newlib/libm/machine/riscv/sf_finite.c > @@ -41,7 +41,7 @@ > int finitef(float x) > { > long fclass = _fclass_f (x); > - return (fclass & FCLASS_INF) == 0; > + return (fclass & (FCLASS_INF | FCLASS_NAN)) == 0; > } > #else > #include "../../common/sf_finite.c" > -- > 2.28.0 Both patches pushed. Sending a cover letter per `git format-patch --cover-letter ...' would be nice when sending patch series. Thanks, Corinna