From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 5E284385DC37 for ; Tue, 10 Nov 2020 08:45:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5E284385DC37 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-298-Me4ENvRhOpyRxt69Ae8BWw-1; Tue, 10 Nov 2020 03:45:47 -0500 X-MC-Unique: Me4ENvRhOpyRxt69Ae8BWw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0857B802B60 for ; Tue, 10 Nov 2020 08:45:47 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-113-240.ams2.redhat.com [10.36.113.240]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CF2486EF68 for ; Tue, 10 Nov 2020 08:45:46 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 585ADA80CFE; Tue, 10 Nov 2020 09:45:45 +0100 (CET) Date: Tue, 10 Nov 2020 09:45:45 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] libc/include/newlib.h: Fix C++ compilation issue Message-ID: <20201110084545.GB33165@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <1604957620-8058-1-git-send-email-joel@rtems.org> MIME-Version: 1.0 In-Reply-To: <1604957620-8058-1-git-send-email-joel@rtems.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2020 08:45:51 -0000 On Nov 9 15:33, Joel Sherrill wrote: > --- > newlib/libc/include/devctl.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/newlib/libc/include/devctl.h b/newlib/libc/include/devctl.h > index 889693e..46305cf 100644 > --- a/newlib/libc/include/devctl.h > +++ b/newlib/libc/include/devctl.h > @@ -69,10 +69,10 @@ int posix_devctl( > size_t nbyte, > int *__restrict dev_info_ptr > ); > -#endif > > #ifdef __cplusplus > } > #endif > > -#endif > +#endif /* _POSIX_26_C_SOURCE */ > +#endif /*_POSIX_DEVCTL_h_ */ > -- > 1.8.3.1 LGTM, but maybe you should add a /* __rtems__ */ comment in line 54, too. Please push. Thanks, Corinna