From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 5F936384242B for ; Mon, 16 Nov 2020 15:01:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5F936384242B Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-487-TnR6IWSAO1i1YaYFFU6CtA-1; Mon, 16 Nov 2020 10:01:08 -0500 X-MC-Unique: TnR6IWSAO1i1YaYFFU6CtA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5A089EC1C3 for ; Mon, 16 Nov 2020 15:01:07 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-115-81.ams2.redhat.com [10.36.115.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2BED45D9CC for ; Mon, 16 Nov 2020 15:01:07 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id AE6A9A80940; Mon, 16 Nov 2020 16:01:05 +0100 (CET) Date: Mon, 16 Nov 2020 16:01:05 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] Fix return type of __locale_ctype_ptr_l() Message-ID: <20201116150105.GC41926@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20201116134023.10709-1-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: <20201116134023.10709-1-sebastian.huber@embedded-brains.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Nov 2020 15:01:12 -0000 On Nov 16 14:40, Sebastian Huber wrote: > This prevents warnings like this: > > ctype.h:118:9: warning: return discards 'const' qualifier from pointer > target type > --- > newlib/libc/include/ctype.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/newlib/libc/include/ctype.h b/newlib/libc/include/ctype.h > index 8b1013ac0..932a567e2 100644 > --- a/newlib/libc/include/ctype.h > +++ b/newlib/libc/include/ctype.h > @@ -111,7 +111,7 @@ const char *__locale_ctype_ptr (void); > #ifdef __HAVE_LOCALE_INFO__ > const char *__locale_ctype_ptr_l (locale_t); > #else > -static __inline char * > +static __inline const char * > __locale_ctype_ptr_l(locale_t _l) > { > (void)_l; > -- > 2.26.2 Looks good Thanks, Corinna