From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 5237F384242D for ; Tue, 26 Jan 2021 12:35:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5237F384242D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-546-HJQLd2aMNji0WT6u5YBZTw-1; Tue, 26 Jan 2021 07:35:10 -0500 X-MC-Unique: HJQLd2aMNji0WT6u5YBZTw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D19968030A2 for ; Tue, 26 Jan 2021 12:35:09 +0000 (UTC) Received: from calimero.vinschen.de (ovpn-112-118.ams2.redhat.com [10.36.112.118]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A157D19C45 for ; Tue, 26 Jan 2021 12:35:09 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 26115A80D7F; Tue, 26 Jan 2021 13:35:08 +0100 (CET) Date: Tue, 26 Jan 2021 13:35:08 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] Align utimensat() and utimes() with POSIX Message-ID: <20210126123508.GP4393@calimero.vinschen.de> Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20210125121000.72815-1-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: <20210125121000.72815-1-sebastian.huber@embedded-brains.de> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2021 12:35:14 -0000 On Jan 25 13:10, Sebastian Huber wrote: > Change the prototypes to be in line with POSIX. This may fix issues > with new warnings produced by GCC 11. > > Signed-off-by: Sebastian Huber > --- > newlib/libc/include/sys/stat.h | 2 +- > newlib/libc/include/sys/time.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/newlib/libc/include/sys/stat.h b/newlib/libc/include/sys/stat.h > index 8769112b0..9eea7fc6e 100644 > --- a/newlib/libc/include/sys/stat.h > +++ b/newlib/libc/include/sys/stat.h > @@ -153,7 +153,7 @@ int fstatat (int, const char *__restrict , struct stat *__restrict, int); > int mkdirat (int, const char *, mode_t); > int mkfifoat (int, const char *, mode_t); > int mknodat (int, const char *, mode_t, dev_t); > -int utimensat (int, const char *, const struct timespec *, int); > +int utimensat (int, const char *, const struct timespec [2], int); > #endif > #if __POSIX_VISIBLE >= 200809 && !defined(__INSIDE_CYGWIN__) > int futimens (int, const struct timespec *); > diff --git a/newlib/libc/include/sys/time.h b/newlib/libc/include/sys/time.h > index 84a429bf2..fb46771d7 100644 > --- a/newlib/libc/include/sys/time.h > +++ b/newlib/libc/include/sys/time.h > @@ -414,7 +414,7 @@ struct itimerval { > #include > > __BEGIN_DECLS > -int utimes (const char *__path, const struct timeval *__tvp); > +int utimes (const char *, const struct timeval [2]); > > #if __BSD_VISIBLE > int adjtime (const struct timeval *, struct timeval *); > -- > 2.26.2 LGTM, but shouldn't futimens get changed as well? And what about the BSD variants futimes and lutimes? Thanks, Corinna