public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@axis.com>
To: <newlib@sourceware.org>
Subject: [PATCH] Include malloc.h in libc/stdlib/aligned_alloc.c
Date: Wed, 17 Feb 2021 03:14:27 +0100	[thread overview]
Message-ID: <20210217021427.172DC203B5@pchp3.se.axis.com> (raw)

Ok to commit?

Noticed by build-scripts diffing warnings at build-time,
that noticed a regression with my "import" of yesterday's
newlib, compared to the previous newlib from May 2019,
i.e. before the "Reimplement aligned_alloc" rewrite.

Without this, for a bare-iron/simulator target such as cris-elf,
you'll see, at newlib build time:

/x/gccobj/./gcc/xgcc -B/x/gccobj/./gcc/ <many options elided> -c -o lib_a-aligned_alloc.o \
 `test -f 'aligned_alloc.c' || echo '/y/newlib/libc/stdlib/'`aligned_alloc.c
/y/newlib/libc/stdlib/aligned_alloc.c: In function 'aligned_alloc':
/y/newlib/libc/stdlib/aligned_alloc.c:35:10: warning: implicit declaration of function \
 '_memalign_r' [-Wimplicit-function-declaration]
   35 |   return _memalign_r (_REENT, align, size);
      |          ^~~~~~~~~~~
---
 newlib/libc/stdlib/aligned_alloc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/newlib/libc/stdlib/aligned_alloc.c b/newlib/libc/stdlib/aligned_alloc.c
index feb22c24b947..06b3883cfb00 100644
--- a/newlib/libc/stdlib/aligned_alloc.c
+++ b/newlib/libc/stdlib/aligned_alloc.c
@@ -28,6 +28,7 @@
 
 #include <reent.h>
 #include <stdlib.h>
+#include <malloc.h>
 
 void *
 aligned_alloc (size_t align, size_t size)
-- 
2.11.0

brgds, H-P

             reply	other threads:[~2021-02-17  2:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17  2:14 Hans-Peter Nilsson [this message]
2021-02-17 10:02 ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210217021427.172DC203B5@pchp3.se.axis.com \
    --to=hp@axis.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).