From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic310-57.consmr.mail.ir2.yahoo.com (sonic310-57.consmr.mail.ir2.yahoo.com [77.238.177.30]) by sourceware.org (Postfix) with ESMTPS id D5CFB3846077 for ; Sun, 11 Apr 2021 10:32:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D5CFB3846077 X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1618137128; bh=z6K8mBqLALbf8JvoIT0dDr5C4S5qxTAh//TpRrEch98=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=eKavWBMlaOVZqdkdCvJnZGn/QkqELuMtyDcYmtrwtZUDqLynTYLLNeRFLqmWafEz+5+BGgNIUruTnIf6zKrPT6Qmn4H12Giihcn0ytc4Bt+j1CN8CfVFMqJ24RWdZaHiZkWVJ+g7gEqvg47/R1KeK+aEQyl04fx2NXBQ52xBfYMdiDOh9ybw4C94d/HILobWbX/4j/C1D5i0kKCnMkFEQjleDcQA2Oyqd1WoXPKIETpMj/SzY/eywNaklAHIS6nXf1iS33w/MLrD9TJkG8GU5uHt/3EnInj/sqNjzsXwhiNotALNj4N9M0P9SVfpK/Bi/R6ozIZmP0C2+dF8t1E1qw== X-YMail-OSG: UGWwR4cVM1nRPp0UIE4VwISw9UdZGwBsZQuaJVy2Jf1jeSC_4mufPZyx04PHSVi 1r9euxMJmSrNynLMHoDKtzq0SILUJ.qvt7Sbb7U37638A2AFgYVj0MHHyXBuP5mZYgkxVaG0ePmq eMjdE6Hv8ivzvlBIbAOHXB4R5pxQRsb1ktNj_QKrXWckz4HCJq4805pSCo6bQseOdR0SriVKj9_W 8rCAfM31LeA17VdJyTl6XSZkXwzfmU8aeGAeQ8y1u_Qw_6ClEHZCmU_h3wuT.GDXfpIWbrzzbvGG YkPanj.sZAvJXk_7ZcQKBvlJPckoQVGFmbWsZ70nbojoGdJMaygXd3rq1Z2wI2Mz6Dq3tWLSbHr. oz66jHE4WRkoeUfGqPq_YeYJlsIATa0i0LZf8pD30q0QRi766OONzoujkkkI72Riuxpk8KapwKss d8J5F7daI8Kf.41nizdlbtMrqaCMiwe3fvQJxobZssSZ7DcQHgyUcAUc7UGoRzCLSjviAleKIYOQ rpuZvx8TcsSpzp_kE5r8holHw2d_C26GdvoY25IrT3d0qond4VyRYicc9Fbe2.vuAGWIuptRhvk. uHkbxH_iQ1x02i0SFfq1sJtmZfoAi__GxKEYE0fGS3IKiYaHy_gBRxsHAXu.dAf2S7XdxcqofoaS .5OcedTvO6.HY3.Vp5MzGv1FWJYupE5XT16Qbc4D9nR3ryw3Feyd29LTYO93sZhEVnga_dKV9oJ7 8USgoOxXwfhiu8OOs4mvIv0uqwPzzsbyxtHqIXKkHDzwOR.JKoBHXP89.2IWmSoiB0MaR.BVjcJe 9HxKsQ7pHQQZMCH0xfO.FlJO2N8vbBTqY5mNI0f3Ck0FkhFSwYtelHOE.0x6pjuczhvPSC8H4qfh eR.5V7pPXIYq3GPJt1ZjkKQjeaQCeEs_wgnoVPKUM2ZfNN3iCbqHmuyrCCE8Yk1OWQI_zypKod70 TLiAtLX5bdrInTJEztcvdArABPC85Nyo46qPb5x6VRArdZfM.AKa7WAPZsT8wwxAFgeMiWSzVEiC 7BPqUfO6R0OGWyloJ5RBKvl29LUPN8Xu1LmZN8H.CSU1JsOGVR50u0zioxPbPwpvhKpG42J477Bs tnhrHDbqz8C8dI1Q0emx.KQwy1PsIk2TmInG3tVjWMToSnauHVrW7JRI8dg8TkZJb5dB0JzW8L4H JXdLoiHfoGL.b4ICQgC60NYA8EJxrM2u8AFfmSqgVg13d.B1mIyNM4e3g_7O2B3lJXnC1HqS0Zh8 4TWW6FmrMLO19FURI6ACEqRfBmil.5n15ghGmXPX70xWcaRVOYkQogUyWVaJsyEcHHY_vQTqycmi zycKL0A2I2CQe9wp4SaJDrVRIs1IDpi6iX_qAmoXxW83m4LjXu5svUX_c9AB5qzvHEYTX5oVsQIj 9iFmi23c24ifB1JUmNV48qYLg563zoEAWYI.OTHjJBzMxyDFJFrGBZncsqP4IXwze1xXAETG507_ MNfePMahXBFUzPGOCfaBNAmU7l.dI7Ar6sQOOnaCFRAZgLxFaiqVjJQsvLzP..9BNZUUKQyJ8KvN NsfYfSnzeftJC0x9NuXp9g5VK9boD6v4aKa2OToovcOzZmSa6ki_6_WlJ5WsG8ftyFD9VffGlO7Q NWYeod4O6dx5jjPx.lq7iLo19ASq_T3AwvrVnplSEWHWU5uT2zJvyY4qhcGUc2fA_mHdm.Jh823S b3KFmF9gw0CffILf0vDH.vKqcpvT6Vw_jf.Xi4Rh.lpFXh_XaNsRrrY0MoVgY0vcF6owmlu07n5J HUutlykai_8XgbWyLMpj7e8kLyJ7S5M_fj28ve3ko9F4kUpboqCa_v04_X061QXDY5ku2c.NDoa9 NTTm_AFzZl_Zz.iSRuSUUO07cOOwZU0SWgaY1WDCW5UTcQSh9MysM5eNNE7ZDxYDPK1Eam7EvnT0 OUXPWjONJIs1jQs51Yxthg17ZrYtdIJM4FEqAZdkodADWS_Z1KIwGcAleQdz_ZX3GeuT64YPSnhc eeMgkL2MJSrhMrfa86hz0Q6GBfmwgUxJqbJlWuDe6sChXqjhTa.cUiu_htzap8_E5rA6CIr2vFEZ sQBFvgHT9LzEl91j3OA22ZnF1h7ARm8E7BCT7GJ0rc5cWht64BLiIBlcGeFDaNhBia2VgQ9aanJg hJ8hlWK4o.5nNDEZDvT0W8IpV7MKQAQlxU0QkATrcpIQdxBFgD3iEZrjbEa8oaF4ndMnaGfLjyOq GNqxbLhAXxtihSn7w6SmUPqVh2THtY5lmwSmkhEndLjrcJAjMOERj4KDuwFSSXvbnGgXzUxAS0w_ 60OqrSdsVNVxMclYpoZMfXdHv38wZDVPhuf5plpQ2pqGnagutRKnLhRi6lemNLLwX_swRlOZcNwL MSp8j31Fbh0G3W5C9ef.CchAhAYYxVjl_W9LeG70IpHiAi_h97AtGV7B7ue95sVlutIRVC0sA8QE agwdMNbAg0dmQs6qCKdDjcTERdYm_ga9hXjuKwZIWhGcji4fyD.ktmUUKR6OIyZFuBWBneL9F7iF YedcBPWfyM2Q5Ev5YRfOkKN6fKGjl_sBswa1n_gslwXOoXtFUnJvpVKR3o.1nWDmhN6QfD.aY89g 0rQvwgXwblTZjd63.ar.VzBTL.t.Tbdee.XI3bAHSFiW7XLJq6302t8mGY1LDu_E- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Sun, 11 Apr 2021 10:32:08 +0000 Received: by kubenode530.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 38b6bb9a14caf90996ee30ba91936720; Sun, 11 Apr 2021 10:32:03 +0000 (UTC) From: "R. Diez" To: newlib@sourceware.org Subject: [PATCH 0/1] Fix some warnings in the public headers Date: Sun, 11 Apr 2021 12:31:26 +0200 Message-Id: <20210411103126.714706-1-rdiezmail-newlib@yahoo.de> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: <20210411103126.714706-1-rdiezmail-newlib.ref@yahoo.de> X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Apr 2021 10:32:12 -0000 Hi all: I am experimenting with Newlib and I am not using option -isystem , but the normal -I, so I get to see more compilation warnings than usual. Maybe I am seeing more warnings because I am building in C++ mode. I have prepared a patch to fix those warnings, see below. Notes about the patch are: About __ARM_FP: The documentation for __ARM_FP states "Set if hardware floating-point is available", so I was getting an "is not defined, evaluates to 0 [-Wundef]" warning. About _FORTIFY_SOURCE: The GCC manual states "when the _FORTIFY_SOURCE macro is defined to a non-zero value", and that symbol was not defined in my build, so I was getting an "is not defined, evaluates to 0 [-Wundef]" warning. About __assert_func(): I was getting this warning: redundant redeclaration of 'void __assert_func(const char*, int, const char*, const char*)' in same scope [-Wredundant-decls] About __STDC_VERSION__: I was getting an "is not defined, evaluates to 0 [-Wundef]" warning when compiling in C++ mode. About _sig_func: I was getting this warning: warning: unnecessary parentheses in declaration of '_sig_func' [-Wparentheses] Thanks in advance, rdiez R. Diez (1): Fix some compilation warnings. newlib/libc/include/assert.h | 5 ++++- newlib/libc/include/machine/ieeefp.h | 2 +- newlib/libc/include/sys/features.h | 2 +- newlib/libc/include/sys/reent.h | 4 ++-- 4 files changed, 8 insertions(+), 5 deletions(-) -- 2.31.1 >From dfb65e9d0b3e3335318e3cf85828ea4a14e252f0 Mon Sep 17 00:00:00 2001 From: "R. Diez" Date: Sun, 11 Apr 2021 11:48:02 +0200 Subject: [PATCH 1/1] Fix some compilation warnings. Signed-off-by: R. Diez --- newlib/libc/include/assert.h | 5 ++++- newlib/libc/include/machine/ieeefp.h | 2 +- newlib/libc/include/sys/features.h | 2 +- newlib/libc/include/sys/reent.h | 4 ++-- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/newlib/libc/include/assert.h b/newlib/libc/include/assert.h index b9e5e9b4a..a15e7fbae 100644 --- a/newlib/libc/include/assert.h +++ b/newlib/libc/include/assert.h @@ -36,12 +36,15 @@ extern "C" { # endif /* !__ASSERT_FUNC */ #endif /* !NDEBUG */ +#ifndef __ASSERT_WAS_DECLARED /* Prevent "redundant redeclaration" warning when including this file multiple times. */ +#define __ASSERT_WAS_DECLARED void __assert (const char *, int, const char *) _ATTRIBUTE ((__noreturn__)); void __assert_func (const char *, int, const char *, const char *) _ATTRIBUTE ((__noreturn__)); +#endif /* #ifndef __ASSERT_WAS_DECLARED */ -#if __STDC_VERSION__ >= 201112L && !defined __cplusplus +#if !defined __cplusplus && __STDC_VERSION__ >= 201112L # define static_assert _Static_assert #endif diff --git a/newlib/libc/include/machine/ieeefp.h b/newlib/libc/include/machine/ieeefp.h index 3c1f41e03..37f7661cb 100644 --- a/newlib/libc/include/machine/ieeefp.h +++ b/newlib/libc/include/machine/ieeefp.h @@ -78,7 +78,7 @@ # else # define __IEEE_BIG_ENDIAN # endif -# if __ARM_FP & 0x8 +# if defined(__ARM_FP) && (__ARM_FP & 0x8) # define __OBSOLETE_MATH_DEFAULT 0 # endif #else diff --git a/newlib/libc/include/sys/features.h b/newlib/libc/include/sys/features.h index 218807178..65f5af763 100644 --- a/newlib/libc/include/sys/features.h +++ b/newlib/libc/include/sys/features.h @@ -319,7 +319,7 @@ extern "C" { #define __XSI_VISIBLE 0 #endif -#if _FORTIFY_SOURCE > 0 && !defined(__cplusplus) && !defined(__lint__) && \ +#if defined(_FORTIFY_SOURCE) && _FORTIFY_SOURCE > 0 && !defined(__cplusplus) && !defined(__lint__) && \ (__OPTIMIZE__ > 0 || defined(__clang__)) && __GNUC_PREREQ__(4, 1) # if _FORTIFY_SOURCE > 1 # define __SSP_FORTIFY_LEVEL 2 diff --git a/newlib/libc/include/sys/reent.h b/newlib/libc/include/sys/reent.h index 74b70e9c0..f62e5817b 100644 --- a/newlib/libc/include/sys/reent.h +++ b/newlib/libc/include/sys/reent.h @@ -409,7 +409,7 @@ struct _reent char *_asctime_buf; /* signal info */ - void (**(_sig_func))(int); + void (**_sig_func)(int); # ifndef _REENT_GLOBAL_ATEXIT /* atexit stuff */ @@ -682,7 +682,7 @@ struct _reent # endif /* signal info */ - void (**(_sig_func))(int); + void (**_sig_func)(int); /* These are here last so that __FILE can grow without changing the offsets of the above members (on the off chance that future binary compatibility -- 2.31.1