public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Matt Joyce <mfjoyce2004@gmail.com>
To: newlib@sourceware.org
Cc: Matt Joyce <mfjoyce2004@gmail.com>
Subject: [PATCH 0/1] V2 Implementation of sig2str/str2sig
Date: Sat, 24 Jul 2021 10:37:29 +0200	[thread overview]
Message-ID: <20210724083730.16959-1-mfjoyce2004@gmail.com> (raw)

Dear Newlib Maintainers,

I have updated the following on my initial patch:

1) Added Makefile entries to build new file
2) Edited definition of SIG2STR_MAX as discussed
3) Added code for "RTMAX-m" in sig2str
4) Added check for whether RTMIN==RTMAX
5) Removed <signum> from "Unknown signal" error message. I reasoned
that this would be ok because the standard does not mention any
error message anyway and it could potentially avoid problems with
the length of the string representation of the invalid signum
exceeding the length of the SIG2STR_MAX sized buffer.

Standing by for any further feedback. Thank you very much for your
time!

Matt Joyce (1):
  libc: Added implementations and prototypes for sig2str/str2sig methods

 newlib/libc/include/sys/signal.h |  16 ++
 newlib/libc/signal/Makefile.am   |   4 +-
 newlib/libc/signal/sig2str.c     | 257 +++++++++++++++++++++++++++++++
 3 files changed, 275 insertions(+), 2 deletions(-)
 create mode 100644 newlib/libc/signal/sig2str.c

-- 
2.31.1


             reply	other threads:[~2021-07-24  8:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-24  8:37 Matt Joyce [this message]
2021-07-24  8:37 ` [PATCH 1/1] libc: Added implementations and prototypes for Matt Joyce
2021-07-28  9:11   ` Corinna Vinschen
2021-07-28 15:25     ` Brian Inglis
2021-07-28 18:46       ` Corinna Vinschen
2021-07-28 19:42         ` Joel Sherrill
     [not found]           ` <DM3P110MB0522CE441CAB289B69DE18B49AEA9@DM3P110MB0522.NAMP110.PROD.OUTLOOK.COM>
2021-07-28 19:54             ` Fw: " C Howland
2021-07-28 20:13               ` Joel Sherrill
2021-07-29  9:23                 ` Corinna Vinschen
2021-07-29 14:45                   ` Eric Blake
2021-07-29 15:29                   ` Brian Inglis
2021-07-29 15:45                     ` Corinna Vinschen
2021-07-29 15:29                   ` Brian Inglis
2021-07-29  2:51         ` Brian Inglis
2021-07-28 18:40     ` Corinna Vinschen
2021-07-29  4:59       ` Matthew Joyce
2021-07-29  9:27         ` Corinna Vinschen
2021-07-29 14:41     ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210724083730.16959-1-mfjoyce2004@gmail.com \
    --to=mfjoyce2004@gmail.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).