From: Mike Frysinger <vapier@gentoo.org>
To: newlib@sourceware.org
Subject: [PATCH] libgloss: epiphany: rename symbol prefix cache var
Date: Wed, 15 Sep 2021 00:40:29 -0400 [thread overview]
Message-ID: <20210915044029.18149-1-vapier@gentoo.org> (raw)
Autoconf emits a warning for this:
configure.ac:75: warning: AC_CACHE_VAL(libc_symbol_prefix, ...): suspicious cache-id, must contain _cv_ to be cached
Rename the variable to match the naming in libnosys/ subdir.
---
libgloss/epiphany/configure | 16 ++++++++--------
libgloss/epiphany/configure.ac | 12 ++++++------
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/libgloss/epiphany/configure b/libgloss/epiphany/configure
index e273d80ab3cb..f9b524fc4ed2 100755
--- a/libgloss/epiphany/configure
+++ b/libgloss/epiphany/configure
@@ -2030,13 +2030,13 @@ $as_echo "#define HAVE_ASM_POPSECTION_DIRECTIVE 1" >>confdefs.h
# script work it out.
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for symbol prefix" >&5
$as_echo_n "checking for symbol prefix... " >&6; }
-if ${libc_symbol_prefix+:} false; then :
+if ${libc_cv_symbol_prefix+:} false; then :
$as_echo_n "(cached) " >&6
else
cat > conftest.c <<\EOF
foo () { }
EOF
-libc_symbol_prefix=none
+libc_cv_symbol_prefix=none
if { ac_try='${CC-cc} -S conftest.c -o - | fgrep "\$foo" > /dev/null'
{ { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
(eval $ac_try) 2>&5
@@ -2044,7 +2044,7 @@ if { ac_try='${CC-cc} -S conftest.c -o - | fgrep "\$foo" > /dev/null'
$as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
test $ac_status = 0; }; };
then
- libc_symbol_prefix='$'
+ libc_cv_symbol_prefix='$'
else
if { ac_try='${CC-cc} -S conftest.c -o - | fgrep "_foo" > /dev/null'
{ { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
@@ -2053,17 +2053,17 @@ else
$as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
test $ac_status = 0; }; };
then
- libc_symbol_prefix=_
+ libc_cv_symbol_prefix=_
fi
fi
rm -f conftest*
fi
-{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_symbol_prefix" >&5
-$as_echo "$libc_symbol_prefix" >&6; }
-if test $libc_symbol_prefix != none; then
+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_symbol_prefix" >&5
+$as_echo "$libc_cv_symbol_prefix" >&6; }
+if test $libc_cv_symbol_prefix != none; then
cat >>confdefs.h <<_ACEOF
-#define __SYMBOL_PREFIX "$libc_symbol_prefix"
+#define __SYMBOL_PREFIX "$libc_cv_symbol_prefix"
_ACEOF
else
diff --git a/libgloss/epiphany/configure.ac b/libgloss/epiphany/configure.ac
index a7bd11a8148a..6c7ab3780cfe 100644
--- a/libgloss/epiphany/configure.ac
+++ b/libgloss/epiphany/configure.ac
@@ -72,24 +72,24 @@ AC_DEFINE(HAVE_ASM_POPSECTION_DIRECTIVE, 1,
# Sort out what the symbol prefix is (we could just fix it as '_', but let the
# script work it out.
-AC_CACHE_CHECK([for symbol prefix], libc_symbol_prefix, [dnl
+AC_CACHE_CHECK([for symbol prefix], libc_cv_symbol_prefix, [dnl
cat > conftest.c <<\EOF
foo () { }
EOF
dnl
-libc_symbol_prefix=none
+libc_cv_symbol_prefix=none
if AC_TRY_COMMAND([${CC-cc} -S conftest.c -o - | fgrep "\$foo" > /dev/null]);
then
- libc_symbol_prefix='$'
+ libc_cv_symbol_prefix='$'
else
if AC_TRY_COMMAND([${CC-cc} -S conftest.c -o - | fgrep "_foo" > /dev/null]);
then
- libc_symbol_prefix=_
+ libc_cv_symbol_prefix=_
fi
fi
rm -f conftest* ])
-if test $libc_symbol_prefix != none; then
- AC_DEFINE_UNQUOTED(__SYMBOL_PREFIX, "$libc_symbol_prefix", [symbol prefix])
+if test $libc_cv_symbol_prefix != none; then
+ AC_DEFINE_UNQUOTED(__SYMBOL_PREFIX, "$libc_cv_symbol_prefix", [symbol prefix])
else
AC_DEFINE(__SYMBOL_PREFIX, "", [symbol prefix])
fi
--
2.33.0
reply other threads:[~2021-09-15 4:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915044029.18149-1-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).