From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: newlib@sourceware.org
Cc: devel@rtems.org
Subject: [PATCH v2 2/4] sys/tree.h: Simplify chain of conditions
Date: Tue, 5 Oct 2021 17:33:42 +0200 [thread overview]
Message-ID: <20211005153344.91266-4-sebastian.huber@embedded-brains.de> (raw)
In-Reply-To: <20211005153344.91266-1-sebastian.huber@embedded-brains.de>
In RB_GENERATE_REMOVE_COLOR() simplify a chain of conditions of the following
pattern
if (x) {
...
} else if (!x) {
...
}
to
if (x) {
...
} else {
...
}
---
newlib/libc/include/sys/tree.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/newlib/libc/include/sys/tree.h b/newlib/libc/include/sys/tree.h
index 15831c7dd..180809e9b 100644
--- a/newlib/libc/include/sys/tree.h
+++ b/newlib/libc/include/sys/tree.h
@@ -528,7 +528,7 @@ name##_RB_REMOVE_COLOR(struct name *head, struct type *parent) \
RB_ROTATE_LEFT(head, tmp, oright, field); \
RB_COLOR(oright, field) = RB_BLACK; \
tmp = oright; \
- } else if (!RB_ISRED(RB_LEFT(tmp, field), field)) { \
+ } else { \
RB_COLOR(tmp, field) = RB_RED; \
elm = parent; \
parent = RB_PARENT(elm, field); \
--
2.26.2
next prev parent reply other threads:[~2021-10-05 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 15:33 [PATCH v2 0/4] Optimize red-black tree insert/extract Sebastian Huber
2021-10-05 15:33 ` [PATCH v2] Align *utime*() with POSIX/glibc Sebastian Huber
2021-10-05 15:35 ` Sebastian Huber
2021-10-05 15:33 ` [PATCH v2 1/4] sys/tree.h: Simplify loop condition Sebastian Huber
2021-10-05 15:33 ` Sebastian Huber [this message]
2021-10-05 15:33 ` [PATCH v2 3/4] sys/tree.h: Add parent rotations Sebastian Huber
2021-10-05 15:33 ` [PATCH v2 4/4] sys/tree.h: Red child with black sibling rotations Sebastian Huber
2021-10-06 18:10 ` [PATCH v2 0/4] Optimize red-black tree insert/extract Jeff Johnston
2021-10-07 12:10 ` Sebastian Huber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005153344.91266-4-sebastian.huber@embedded-brains.de \
--to=sebastian.huber@embedded-brains.de \
--cc=devel@rtems.org \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).