From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3MaBgYQoKBgYihokyotmkxmuumrk.iustk2rohyu0xik2gxk.uxm@flex--cbiesinger.bounces.google.com> Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by sourceware.org (Postfix) with ESMTPS id C3E9C3858400 for ; Fri, 8 Oct 2021 19:46:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C3E9C3858400 Received: by mail-yb1-xb4a.google.com with SMTP id v70-20020a256149000000b005ba4d61ea0fso10026623ybb.22 for ; Fri, 08 Oct 2021 12:46:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=xssHkUEpq6g++5qvv0LFk9JGT3Kgj5vrlk50HmvafVk=; b=1LHmylms48MM3rebkpQgh5/0j4RndSp1jfwvSaUWH2xSrKSIxmd/msFdZeQ1LOiwWX g2TGpnd5cU5qTw1UIgkX+qDIctDMt+J56p4kkWI55jnA5+Y9smZU68ni4tDbMrqITZ6k smbzMzzcztX17wCveX8yrBJVCXdeXZCWthzKSEFna1rMRPm5sPOF7KcrHJWQ2l/oSA0T VCEEqDLdNmc7gNM6Irh5PQXZcH7EC+xlY4Yu2qmS4tWULQh+s3PqGF+JWzmILwX1Lon8 JOMAX50g1XFCA0GcpenmpaOQ0EZbYi5ZVhzfe23D5QszZdLW+iiSlC32y8J3cuhny7X4 HOeg== X-Gm-Message-State: AOAM531mjV3tH/WJEDNKLywvwfo1eUhWqkZaRUlRQWv8Ju+Sf6OnSX+5 MOJ6mqebThgAXUeg1j5q65uL9welaGAJjphmaA7Up4R+5BsOdOnPXkxt72IDrmwhUtICkuVMRG1 aVuc9yeizhZr+MuRBV+1EoOiMTuCL2DeoS0dPL4Hf1wBU4AjGPAlHZc9NK7xmpEc7ZI9HvEg= X-Google-Smtp-Source: ABdhPJzidzRKrVM5i0OdYpg3yIhEzGX7lFo8IXzL9in95XAETYMkU/v//ujzzvbQ+bofKV2ny0nqWLzTduHkPdDS X-Received: from cbiesinger2.wat.corp.google.com ([2620:15c:0:26:df0c:7569:aaab:fc36]) (user=cbiesinger job=sendgmr) by 2002:a25:5e06:: with SMTP id s6mr5868730ybb.175.1633722417233; Fri, 08 Oct 2021 12:46:57 -0700 (PDT) Date: Fri, 8 Oct 2021 15:46:54 -0400 Message-Id: <20211008194654.627119-1-cbiesinger@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.33.0.882.g93a45727a2-goog Subject: [PATCH] Unconditionally declare strsignal From: Christian Biesinger To: newlib@sourceware.org Cc: vapier@gentoo.org, Christian Biesinger Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-18.3 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Oct 2021 19:46:59 -0000 Currently, newlib does not declare strsignal if DEFS_H is defined, ostensibly to work around a gdb bug. However, gdb itself compiles even with this ifndef removed, and this makes sim (another part of gdb) fail to compile. Since it is not clear exactly what issue this was working around, this patch just removes that ifndef. --- newlib/libc/include/string.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/newlib/libc/include/string.h b/newlib/libc/include/string.h index 60e837bc0..ec74b10d5 100644 --- a/newlib/libc/include/string.h +++ b/newlib/libc/include/string.h @@ -130,9 +130,7 @@ char *strlwr (char *); char *strupr (char *); #endif -#ifndef DEFS_H /* Kludge to work around problem compiling in gdb */ char *strsignal (int __signo); -#endif #ifdef __CYGWIN__ int strtosigno (const char *__name); -- 2.33.0.882.g93a45727a2-goog