From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: newlib@sourceware.org
Subject: Re: [PATCH] frexpl: Support smaller long double.
Date: Thu, 2 Dec 2021 18:50:18 +0900 [thread overview]
Message-ID: <20211202185018.96b29d1060a05dfbdf078b60@nifty.ne.jp> (raw)
In-Reply-To: <mwr1av1lbk.fsf@tomate.loria.fr>
On Thu, 02 Dec 2021 09:07:43 +0100
Paul Zimmermann wrote:
> about https://sourceware.org/pipermail/newlib/2021/018738.html:
>
> > This patch add support for smaller long double, LDBL_MANT_DIG is 24 or 53.
>
> are you sure LDBL_MANT_DIG can be 24 in radix 2? As far as I know, the standard
> requires LDBL_DIG >= 10, and a floating-point number with LDBL_DIG decimal
> digits should be converted to a long double and back to LDBL_DIG digits
> without any modification, which requires LDBL_MANT_DIG >= 34.
>
> Also the standard says in 6.2.5: "the set of values of the
> type double is a subset of the set of values of the type long double."
Thanks for pointing out this.
I now have read ISO/IEC9899 standard draft, and confirm that it requires
LDBL_DIG >= 10. It also says DBL_DIG >= 10. If this means LDBL_MANT_DIG
and DBL_MANT_DIG >= 34, double also should not be DBL_MANT_DIG == 24.
However, newlib supports _DOUBLE_IS_32BITS. I guess some platfors
does not comply with the standard. So I consider long double can be
smaller in such platforms. However if both double and long double are
32bit, frexpl() calls frexp() (double version). So this patch does more
than necessary.
I will submit v2 patch, which removes following LDBM_MANT_DIG == 24
case.
+# if (LDBL_MANT_DIG == 24) /* 32-bit long double */
+static const double scale = 0x1p25;
+
+union ldbl {
+ long double x;
+ struct {
+# ifdef __IEEE_LITTLE_ENDIAN /* for Intel CPU */
+ __uint32_t frac:23;
+ __uint32_t exp:8;
+ __uint32_t sign:1;
+# endif
+# ifdef __IEEE_BIG_ENDIAN
+# ifndef ___IEEE_BYTES_LITTLE_ENDIAN
+ __uint32_t sign:1;
+ __uint32_t exp:8;
+ __uint32_t frac:23;
+# else /* ARMEL without __VFP_FP__ */
+ __uint32_t frac:23;
+ __uint32_t exp:8;
+ __uint32_t sign:1;
+# endif
+# endif
+ } u32;
+};
--
Takashi Yano <takashi.yano@nifty.ne.jp>
next prev parent reply other threads:[~2021-12-02 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 8:07 Paul Zimmermann
2021-12-02 9:50 ` Takashi Yano [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-12-01 19:34 Takashi Yano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202185018.96b29d1060a05dfbdf078b60@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).