From: Matthew Joyce <matthew.joyce@embedded-brains.de>
To: newlib@sourceware.org
Subject: [PATCH v2 07/11] Add CLEANUP_FILE define
Date: Thu, 12 May 2022 14:11:39 +0200 [thread overview]
Message-ID: <20220512121143.21473-8-matthew.joyce@embedded-brains.de> (raw)
In-Reply-To: <20220512121143.21473-1-matthew.joyce@embedded-brains.de>
From: Matt Joyce <matthew.joyce@embedded-brains.de>
Define the configuration-dependent constant CLEANUP_FILE for use in
cleanup_stdio(). This will reduce duplicate code during the addition
of a dedicated stdio atexit handler in a follow-on patch.
---
newlib/libc/stdio/findfp.c | 38 +++++++++++++++++++-------------------
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/newlib/libc/stdio/findfp.c b/newlib/libc/stdio/findfp.c
index 7434c343c..5b0402ac1 100644
--- a/newlib/libc/stdio/findfp.c
+++ b/newlib/libc/stdio/findfp.c
@@ -39,6 +39,21 @@ const struct __sFILE_fake __sf_fake_stderr =
__FILE __sf[3];
#endif
+#ifdef _STDIO_BSD_SEMANTICS
+ /* BSD and Glibc systems only flush streams which have been written to
+ at exit time. Calling flush rather than close for speed, as on
+ the aforementioned systems. */
+#define CLEANUP_FILE __sflushw_r
+#else
+ /* Otherwise close files and flush read streams, too.
+ Note we call flush directly if "--enable-lite-exit" is in effect. */
+#ifdef _LITE_EXIT
+#define CLEANUP_FILE _fflush_r
+#else
+#define CLEANUP_FILE _fclose_r
+#endif
+#endif
+
#if (defined (__OPTIMIZE_SIZE__) || defined (PREFER_SIZE_OVER_SPEED))
_NOINLINE_STATIC void
#else
@@ -208,30 +223,15 @@ found:
static void
cleanup_stdio (struct _reent *ptr)
{
- int (*cleanup_func) (struct _reent *, FILE *);
-#ifdef _STDIO_BSD_SEMANTICS
- /* BSD and Glibc systems only flush streams which have been written to
- at exit time. Calling flush rather than close for speed, as on
- the aforementioned systems. */
- cleanup_func = __sflushw_r;
-#else
- /* Otherwise close files and flush read streams, too.
- Note we call flush directly if "--enable-lite-exit" is in effect. */
-#ifdef _LITE_EXIT
- cleanup_func = _fflush_r;
-#else
- cleanup_func = _fclose_r;
-#endif
-#endif
#ifdef _REENT_GLOBAL_STDIO_STREAMS
if (ptr->_stdin != &__sf[0])
- (*cleanup_func) (ptr, ptr->_stdin);
+ CLEANUP_FILE (ptr, ptr->_stdin);
if (ptr->_stdout != &__sf[1])
- (*cleanup_func) (ptr, ptr->_stdout);
+ CLEANUP_FILE (ptr, ptr->_stdout);
if (ptr->_stderr != &__sf[2])
- (*cleanup_func) (ptr, ptr->_stderr);
+ CLEANUP_FILE (ptr, ptr->_stderr);
#endif
- (void) _fwalk_reent (ptr, cleanup_func);
+ (void) _fwalk_reent (ptr, CLEANUP_FILE);
}
/*
--
2.31.1
next prev parent reply other threads:[~2022-05-12 12:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 12:11 [PATCH v2 00/11] Decouple global file object list from _GLOBAL_REENT Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 01/11] Remove duplicate stdio initializations Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 02/11] Remove duplicate sglue initializations Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 03/11] Declare global __sf[] only once Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 04/11] Add two __sglue initialization macros Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 05/11] Remove __sinit_locks / __sinit_recursive_mutex Matthew Joyce
2022-05-12 13:25 ` Torbjorn SVENSSON
2022-05-12 13:51 ` Sebastian Huber
2022-05-12 12:11 ` [PATCH v2 06/11] Move __sglue initializations to __sfp() Matthew Joyce
2022-05-12 12:11 ` Matthew Joyce [this message]
2022-05-12 12:11 ` [PATCH v2 08/11] Add stdio_exit_handler() Matthew Joyce
2022-05-12 19:11 ` Corinna Vinschen
2022-05-17 8:36 ` Takashi Yano
2022-05-17 10:13 ` Sebastian Huber
2022-05-12 12:11 ` [PATCH v2 09/11] stdio: Replace _fwalk_reent() with _fwalk_sglue() Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 10/11] Add global __sglue object for all configurations Matthew Joyce
2022-05-12 12:11 ` [PATCH v2 11/11] Remove __sglue member for one configuration Matthew Joyce
2022-05-12 19:09 ` Corinna Vinschen
2022-05-12 19:14 ` [PATCH v2 00/11] Decouple global file object list from _GLOBAL_REENT Corinna Vinschen
2022-05-12 19:44 ` Corinna Vinschen
2022-05-13 5:44 ` Sebastian Huber
2022-05-13 7:53 ` Corinna Vinschen
2022-05-13 10:54 ` Sebastian Huber
2022-05-13 11:20 ` Corinna Vinschen
2022-05-13 8:03 ` Corinna Vinschen
2022-05-13 11:20 ` Sebastian Huber
2022-05-13 11:30 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512121143.21473-8-matthew.joyce@embedded-brains.de \
--to=matthew.joyce@embedded-brains.de \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).