From: jiawei <jiawei@iscas.ac.cn>
To: newlib@sourceware.org
Cc: msebor@redhat.com, sebastian.huber@embedded-brains.de,
maxim.blinov@embecosm.com, palmer@dabbelt.com,
jim.wilson.gcc@gmail.com, kito.cheng@sifive.com,
wuwei2016@iscas.ac.cn, Jia-Wei Chen <jiawei@iscas.ac.cn>
Subject: [PATCH] newlib: libc: reente.h: remove unnecessary parentheses
Date: Wed, 18 May 2022 18:03:18 +0800 [thread overview]
Message-ID: <20220518100318.890201-1-jiawei@iscas.ac.cn> (raw)
From: Jia-Wei Chen <jiawei@iscas.ac.cn>
The compiler warns the double parentheses are unnecessary in some
target, and cause fail cases when doing some testcases in regression.
gcc/testsuite/g++.dg/warn/Wstringop-overflow-6.C
Remove the unnecessary parentheses will fix it. See more details in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85775
Same like in commit 05425831290c9869bc7987b5df3ce84aa4f19a6c,
Author: Maxim Blinov <maxim.blinov@embecosm.com>
Date: Thu Jul 22 22:41:42 2021 +0100
Remove unneccesary parenthesis around declarator
Thanks for Sebastian Huber's remind!
ChangeLog:
* newlib/libc/include/sys/reent.h (struct _reent): Remove
* additonal parentheses.
---
newlib/libc/include/sys/reent.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/newlib/libc/include/sys/reent.h b/newlib/libc/include/sys/reent.h
index 4a3cfbd34..64d76c27c 100644
--- a/newlib/libc/include/sys/reent.h
+++ b/newlib/libc/include/sys/reent.h
@@ -421,7 +421,7 @@ struct _reent
char *_asctime_buf;
/* signal info */
- void (**(_sig_func))(int);
+ void (** _sig_func)(int);
#ifdef _REENT_BACKWARD_BINARY_COMPAT
struct _atexit *_reserved_6;
--
2.25.1
next reply other threads:[~2022-05-18 10:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 10:03 jiawei [this message]
2022-05-18 10:39 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518100318.890201-1-jiawei@iscas.ac.cn \
--to=jiawei@iscas.ac.cn \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=maxim.blinov@embecosm.com \
--cc=msebor@redhat.com \
--cc=newlib@sourceware.org \
--cc=palmer@dabbelt.com \
--cc=sebastian.huber@embedded-brains.de \
--cc=wuwei2016@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).