From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) by sourceware.org (Postfix) with ESMTP id 986E23857805 for ; Wed, 18 May 2022 10:03:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 986E23857805 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [47.112.183.207]) by APP-01 (Coremail) with SMTP id qwCowAAnfxZ1xIRi79VeCA--.27211S2; Wed, 18 May 2022 18:03:34 +0800 (CST) From: jiawei To: newlib@sourceware.org Cc: msebor@redhat.com, sebastian.huber@embedded-brains.de, maxim.blinov@embecosm.com, palmer@dabbelt.com, jim.wilson.gcc@gmail.com, kito.cheng@sifive.com, wuwei2016@iscas.ac.cn, Jia-Wei Chen Subject: [PATCH] newlib: libc: reente.h: remove unnecessary parentheses Date: Wed, 18 May 2022 18:03:18 +0800 Message-Id: <20220518100318.890201-1-jiawei@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: qwCowAAnfxZ1xIRi79VeCA--.27211S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Jr1rWFW7Xw4ruFy5CFWfKrg_yoW8JrWrpa 93uF1UKFWUGryrAwn7uw1xXFyxAasxKw13Ga45Z3WfZr45J34UXF4qkr43CryrWFZIg3y7 CrWSqw1UJr4jqaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUyC14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1l42xK82IYc2Ij64vI r41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8Gjc xK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0 cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8V AvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7Cj xVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUdHUDUUUUU= X-Originating-IP: [47.112.183.207] X-CM-SenderInfo: 5mld4v3l6l2u1dvotugofq/1tbiCQcKAF02bLdV1AAAs1 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2022 10:03:44 -0000 From: Jia-Wei Chen The compiler warns the double parentheses are unnecessary in some target, and cause fail cases when doing some testcases in regression. gcc/testsuite/g++.dg/warn/Wstringop-overflow-6.C Remove the unnecessary parentheses will fix it. See more details in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85775 Same like in commit 05425831290c9869bc7987b5df3ce84aa4f19a6c, Author: Maxim Blinov Date: Thu Jul 22 22:41:42 2021 +0100 Remove unneccesary parenthesis around declarator Thanks for Sebastian Huber's remind! ChangeLog: * newlib/libc/include/sys/reent.h (struct _reent): Remove * additonal parentheses. --- newlib/libc/include/sys/reent.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/newlib/libc/include/sys/reent.h b/newlib/libc/include/sys/reent.h index 4a3cfbd34..64d76c27c 100644 --- a/newlib/libc/include/sys/reent.h +++ b/newlib/libc/include/sys/reent.h @@ -421,7 +421,7 @@ struct _reent char *_asctime_buf; /* signal info */ - void (**(_sig_func))(int); + void (** _sig_func)(int); #ifdef _REENT_BACKWARD_BINARY_COMPAT struct _atexit *_reserved_6; -- 2.25.1