From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: newlib@sourceware.org
Subject: [PATCH] powerpc/setjmp: Fix 64-bit buffer alignment
Date: Mon, 7 Nov 2022 16:48:56 +0100 [thread overview]
Message-ID: <20221107154856.34249-1-sebastian.huber@embedded-brains.de> (raw)
The rlwinm is a word-size instruction which clears the remaining 32 bits of a
64-bit register. Use clrrdi in 64-bit configurations.
---
newlib/libc/machine/powerpc/setjmp.S | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/newlib/libc/machine/powerpc/setjmp.S b/newlib/libc/machine/powerpc/setjmp.S
index 3a6fa4a58..c7af5b105 100644
--- a/newlib/libc/machine/powerpc/setjmp.S
+++ b/newlib/libc/machine/powerpc/setjmp.S
@@ -8,11 +8,19 @@
FUNC_START(setjmp)
#ifdef __ALTIVEC__
addi 3,3,15 # align Altivec to 16 byte boundary
+#if __powerpc64__
+ clrrdi 3,3,4
+#else
rlwinm 3,3,0,0,27
+#endif
#else
addi 3,3,7 # align to 8 byte boundary
+#if __powerpc64__
+ clrrdi 3,3,3
+#else
rlwinm 3,3,0,0,28
#endif
+#endif
#if __SPE__
/* If we are E500, then save 64-bit registers. */
evstdd 1,0(3) # offset 0
@@ -193,11 +201,19 @@ FUNC_END(setjmp)
FUNC_START(longjmp)
#ifdef __ALTIVEC__
addi 3,3,15 # align Altivec to 16 byte boundary
+#if __powerpc64__
+ clrrdi 3,3,4
+#else
rlwinm 3,3,0,0,27
+#endif
#else
addi 3,3,7 # align to 8 byte boundary
+#if __powerpc64__
+ clrrdi 3,3,3
+#else
rlwinm 3,3,0,0,28
#endif
+#endif
#if __SPE__
/* If we are E500, then restore 64-bit registers. */
evldd 1,0(3) # offset 0
--
2.35.3
next reply other threads:[~2022-11-07 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 15:48 Sebastian Huber [this message]
2022-11-07 16:33 ` Corinna Vinschen
2022-11-10 15:19 ` Sebastian Huber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107154856.34249-1-sebastian.huber@embedded-brains.de \
--to=sebastian.huber@embedded-brains.de \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).