From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dmta0012.nifty.com (mta-snd00009.nifty.com [106.153.226.41]) by sourceware.org (Postfix) with ESMTPS id A1B303858C5F for ; Wed, 8 Nov 2023 22:00:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A1B303858C5F Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A1B303858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=106.153.226.41 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699480850; cv=none; b=DGLo1R0xn1+PGuCFsh90xFzzPZqBCHE61XGAlEraxG1NYVTbC6xyloguKbt5PhXH7mOASPj4z3MEuitQ9aYeDPVYPkrd/MoWExPxtkIjxiFA3XiZetK5a4v3FYb3hE48KlC4Ox1jd7oFQbD9EY/I7qaLwLduBnvCY2rxviud6Ms= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699480850; c=relaxed/simple; bh=nW9VBQUfGNEe9jbqtzULJmneKFxBq8S8v9X0GY3QyjY=; h=Date:From:To:Subject:Message-Id:Mime-Version; b=LC1NyZtDY4FlWyJgL/PzfyyPtHwF7CO2daWm/1yFBesnlC7DHGAKdhXa5umnQ9cqJbhZnfxZ5EJl22gIzk+B4n8OzTCUS1F0Hngf9nGUsLfWhkzQNnzPEyPGRM6itWFeXyBLQ/x9iE0BT6PA7oiYZaaLYTq4MIiVt6HZ3Owj5cI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from HP-Z230 by dmta0012.nifty.com with ESMTP id <20231108220046583.OYNX.29240.HP-Z230@nifty.com> for ; Thu, 9 Nov 2023 07:00:46 +0900 Date: Thu, 9 Nov 2023 07:00:47 +0900 From: Takashi Yano To: newlib@sourceware.org Subject: Re: [PATCH v4] newlib: libc: Fix crash on fprintf to a wide-oriented stream. Message-Id: <20231109070047.e41d88c5520247ff6f7e5f96@nifty.ne.jp> In-Reply-To: References: <20231108120403.643-1-takashi.yano@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 8 Nov 2023 20:40:57 +0100 Corinna Vinschen wrote: > On Nov 8 21:04, Takashi Yano wrote: > > --- a/newlib/libc/stdio/local.h > > +++ b/newlib/libc/stdio/local.h > > +#define ORIENT(fp,ori) \ > > + ( \ > > + ( \ > > + ((fp)->_flags & __SORD) ? \ > > + 0 \ > > + : \ > > + ( \ > > You're missing to set (fp)->_flags |= __SORD here. > > > + (ori > 0) ? \ > > + ((fp)->_flags2 |= __SWID) \ > > + : \ > > + ((fp)->_flags2 &= ~__SWID) \ > > + ) \ > > + ), \ > > + (((fp)->_flags2 & __SWID) ? 1 : -1) \ > > + ) Argh! Thanks. -- Takashi Yano