From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dmta1018.nifty.com (mta-snd01011.nifty.com [106.153.227.43]) by sourceware.org (Postfix) with ESMTPS id 091C33858D3C for ; Thu, 9 Nov 2023 15:36:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 091C33858D3C Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 091C33858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=106.153.227.43 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699544168; cv=none; b=Yy9Et8Jsn6rxbZC9WQFQmXY08HXVIxD0rjpxgyaWQGKhqClHjTqke8xMBV6KPSmd3NkDIMTRpPG7Sj+dA+9B3w5/P0GegTQV098y5NyCIyMDM8YPUfYn9B0lXjOnJQvaixoExMkO+Af1uYnJXm3rq2GVpqI2binCaTIIRnbbSFw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699544168; c=relaxed/simple; bh=37zyt0ukVsHeGGKMYCbNuwGWKWYRtMdUc4HbdY4NMUc=; h=Date:From:To:Subject:Message-Id:Mime-Version; b=R6vJbWCQzqZK1Jb5GKZzaqDwhS/qZexjf6wH6y3T6mZPisdN4q6s+9++0qaIz9s1zbzgRzdjZnQjBPjOC6dPerA9V+jQl25oUV8gs7RKndBlWvQquJNbyQUQnWQk1oMr8S26gBY4TTP8a+anSoBFTmXDQhPUo5mquXlPT3Jx7cs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from HP-Z230 by dmta1018.nifty.com with ESMTP id <20231109153602548.PLSB.56393.HP-Z230@nifty.com> for ; Fri, 10 Nov 2023 00:36:02 +0900 Date: Fri, 10 Nov 2023 00:36:02 +0900 From: Takashi Yano To: newlib@sourceware.org Subject: Re: [PATCH v5] newlib: libc: Fix crash on fprintf to a wide-oriented stream. Message-Id: <20231110003602.909efa12752d9365403db70a@nifty.ne.jp> In-Reply-To: References: <20231108214813.1569-1-takashi.yano@nifty.ne.jp> <20231109192624.8fd1d42b4123b444b095f81f@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 9 Nov 2023 13:49:41 +0100 Corinna Vinschen wrote: > On Nov 9 19:26, Takashi Yano wrote: > > On Thu, 9 Nov 2023 11:08:03 +0100 > > Corinna Vinschen wrote: > > > Looks good, please push. > > > > Thanks. Should this also be applied to cygwin-3_4-branch? > > Tricky question. It's a bugfix, yeah, but a bugfix for an undefined > situation. And it's also a behavioral change. So, from my POV we > shouldn't backport it. I see. I'll push it only for master branch. > But if you have another POV, we can discuss it. It occured to me that > you didn't mention where the testcase is coming from. Was that a > real-world problem? If so, where and in which circumstances? No. It was discovered by an accidental mistake while writing a test case for another problem. -- Takashi Yano