From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by sourceware.org (Postfix) with ESMTPS id C53383858430 for ; Fri, 15 Dec 2023 10:33:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C53383858430 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bootlin.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C53383858430 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.70.183.196 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702636416; cv=none; b=UWsuOLV6zz/nWICNe/KANwE8vmGoX+F0mGZ+0+BkuqK0LiYCHy86n8YwqGCkKMNj9+03sm/cQdfNrXOnFwD/knFzp9ZrHerD7unmrN12R0pQqIcet0k/k/Qo6BNZZfZWYHlrYo6TOcVpyY6qfEcP4pZSxn8/JRSJgk2s/an+4HM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702636416; c=relaxed/simple; bh=msgfaj5YMptmwYQpX10dM9wizsAk32HKFYkIorC5E+k=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=x2Pb2LDATHkTkIVVkjnDfm7WM7KZHKvbWuheTtY0NzteyHPIcARcMUxrglNZm9ayhKCXAQHOFDYC7E9o9g8wIlRuj5qPYMyUtiML9DIJaApzhJRflJFzEwTvhM+ZRXGxms4jXj8UqicAixZgj55da7GIixP3+h01eOnVU5JSeJ8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail.gandi.net (Postfix) with ESMTPSA id 3992AE0002; Fri, 15 Dec 2023 10:33:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1702636413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4S5BHEPsV4sC12m1GgTqGb4LliXKe3tZmz3sgcdjWAs=; b=fG0t1WX2T+M4DGmXRZShS0f5DEAwHVHMCZJ1nb5x495xnt5eH0544rXH7uKz53Y0PshW7A 3fxMjT2UI4HlKuErF4sNQjXEQ9tfNaQb4alvLy6BOeXEjDng1aehubxnbPEJj3DLmRGeCx gjctFyCm2J3p3JMpE3Sa7Ook4QrBn6R1SUbsewKrAX2uesM/Dj/4TkU+Li6ODnxX8DVjEE q/BuaPplClHG8uwq/K317WRE9P/u2f/7d/Gs7x44szJupROyjkX2GEwHOZbRYJ3jO5g/XC TTUUhtF8DBBVh8kqYyupRioCPkfc5N9JEuS4U3L/qpXp3Xpg3jGGMwv3r0B4Cw== Date: Fri, 15 Dec 2023 11:33:32 +0100 From: Thomas Petazzoni To: Neal Frager Cc: , Subject: Re: [PATCH v1 1/1] configure: correct tooldir install path Message-ID: <20231215113332.4a0fd114@windsurf> In-Reply-To: <20231215095529.739093-1-neal.frager@amd.com> References: <20231215095529.739093-1-neal.frager@amd.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: thomas.petazzoni@bootlin.com X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Neal, On Fri, 15 Dec 2023 09:55:29 +0000 Neal Frager wrote: > This patch is required to fix how the newlib headers are installed > when using a sysroot install directory. > > The cross compiler expects headers to be in > .../host/usr/arm-none-eabi/sysroot/usr/include/newlib.h > by default newlib installed the headers into > .../host/usr/arm-none-eabi/sysroot/usr/arm-none-eabi/include/newlib.h > > ${exec_prefix} provides the .../host/usr/arm-none-eabi/sysroot path > ${target_noncanonical} provides an extra arm-none-eabi/ that must be removed. > > Signed-off-by: Neal Frager > Co-developed-by: Chris Wardman > --- > configure | 7 +++++++ > 1 file changed, 7 insertions(+) The configure script is generated from configure.ac, so you should not patch configure but configure.ac. > + --with-install-sysroot use sysroot install directory > --with-debug-prefix-map='A=B C=D ...' > map A to B, C to D ... in debug information > --with-build-config='NAME NAME2...' > @@ -7057,7 +7059,12 @@ esac > > # Some systems (e.g., one of the i386-aix systems the gas testers are > # using) don't handle "\$" correctly, so don't use it here. > +# Check whether --with-install-sysroot was given. > +if test "${with_install_sysroot+set}" = set; then : --with/--without options are usually not used for boolean things, instead --enable/--disable option are used for boolean things. However here, I think that what would make sense is a --with-tooldir option. When not passed, the value is '${exec_prefix}'/${target_noncanonical}, and when passed, the value is the one passed in the option: ./configure ... --with-tooldir=/blabla Best regards, Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com