From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::225]) by sourceware.org (Postfix) with ESMTPS id 26DDE386587A for ; Fri, 15 Dec 2023 17:07:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 26DDE386587A Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bootlin.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 26DDE386587A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4b98:dc4:8::225 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702660063; cv=none; b=f5/NRIMX+h05AxUCP6cVsIOnBCmiCSyBr3zhcvkCJRdS/ZA3sj9K4Ffg2ldhEEjKYdA6dDzPTOvQH0KU76rGDJE/+7MBQkOlOGjqXBixeeHRBYe7mYLEhCxBEGxbDyU8XlfGd3Us9tzJS+2B+8B7qRnqmft6osZ7j6jZiN2CMGo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702660063; c=relaxed/simple; bh=rp7w4glIyKhuX98lqVznTRhzBI0unII4Zvu1oEp8ugE=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Vj9e4PLkgqiRX990zktcE7NHJ3jWtiGbAjB4dGBVuXmVtaCdUOYQqZZCF/9EfpXLz5GnB8bxEhixD01AUJAeIQmIXTLVRFmv+k+BksLgeJ0ljTOsY8vJbmro1C340/h/FZwHU7EPgrMiY41F8IUfLrl+AKxIiG7ebigpPmftV2U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail.gandi.net (Postfix) with ESMTPSA id A72491C0003; Fri, 15 Dec 2023 17:07:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1702660060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u4zUIIDNHv0KMyLWDWsvXp1o9ySjn4buaOUH6l8TwN8=; b=Oobq7w+MC9RozPl4RinL/pP5gAGLIa6w8tRHsH0UP9lkh3lsenpJKUfHtPgST0TDf0WCW0 Q+P5Kko+fsVY1GzKvIbMh3OpU7eA1SNsq8ARiowUG5IZ9ZgrDTP3DDDsg50VUWABVN/wBD 20WITdjN2jFvUN/C6h4eNQjf+uW721WxWK7fpTbgSJBHP6AiecS3Xb2Zlkc/kYWtUPua5p 1Vaoo2B21Jf6FTlCtzSxga5Ykq2RpmJkBy4JRcCmuVbAxyUvHh50WX8irBdU4/TmlwxnEE J6k1iccNueuy9DUPwuGG/9aMhTIFXuHKhSr9sG1yUSJMrpJvtpGMgp9W9OoXrQ== Date: Fri, 15 Dec 2023 18:07:38 +0100 From: Thomas Petazzoni To: "Frager, Neal" Cc: "newlib@sourceware.org" , "cjwfirmware@vxmdesign.com" Subject: Re: [PATCH v1 1/1] configure: correct tooldir install path Message-ID: <20231215180738.4fde7cb9@windsurf> In-Reply-To: References: <20231215095529.739093-1-neal.frager@amd.com> <20231215113332.4a0fd114@windsurf> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: thomas.petazzoni@bootlin.com X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 15 Dec 2023 12:08:37 +0000 "Frager, Neal" wrote: > > The configure script is generated from configure.ac, so you should not > > patch configure but configure.ac. > > When building newlib, I am not seeing the configure script get > generated. If I only patch configure.ac, the configure script stays > the same and my patch appears ignored. > > Do you know what I could be missing? Yes, you need to learn/read a bit about the autotools, and autoconf in particular :-) > I made this correction, and the --with-tooldir option only works > if I patch it directly into the configure script. > > Could you help me figure out what is missing? See above :-) Best regards, Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com