From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 407663858D32 for ; Wed, 27 Dec 2023 03:24:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 407663858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 407663858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703647497; cv=none; b=fi8DypHlmgh/t/iDe41y2T7VRST/Ek0/2kuM8yLmRMIpTBTfIDeaoOV57RRAMVFpgMsfCtjVGFow4Ib+O4U2C6ARHW9LAFwRuU+8mxFLluOLv2qx8Va3tIgicc+NFOXV3Vgo42IN/E/nuNmDcWWO+xEZzuLc3+596onp4owHEgY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703647497; c=relaxed/simple; bh=lp4Uqy0n6hXib21WbOsek0+xpwvGDdVgXLwhEdYg97A=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Ry1HeY6YMuhKrsI0sQACOU3DpMNDXCxIoy3uOXeOPExLbYzYV3rcsNafccNTsJw8ddDlY1YvzHPyDq63QCECC/H30Tves6WXTg1hkoRIQZZyfUMPOizwfzIA0cc19BvAzqvjhIzz6x91ofYh7+tdjr6f7LYWEQ05leQZxrJfMXk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id C8C6D34069F; Wed, 27 Dec 2023 03:24:55 +0000 (UTC) From: Mike Frysinger To: newlib@sourceware.org Subject: [PATCH 1/5] libgloss: msp430: delete outdated/wrong code Date: Tue, 26 Dec 2023 22:24:49 -0500 Message-ID: <20231227032453.13546-1-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The #if 0 & comment imply this code doesn't exist and is never used, except there's another #if Lrun_fini_array section below which *does* define this function, which makes this code comment confusing. This seems to be a hold over of the cleanup of the minrt code in the old commit 884b05b54e4595433c85f8ca9820e88b4c723e38 ("MSP430: Remove .init/.fini sections"). --- libgloss/msp430/crt0.S | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/libgloss/msp430/crt0.S b/libgloss/msp430/crt0.S index 88876cd48300..c0b258f508d2 100644 --- a/libgloss/msp430/crt0.S +++ b/libgloss/msp430/crt0.S @@ -195,20 +195,6 @@ START_CRT_FUNC 0600 run_init_array END_CRT_FUNC run_init_array #endif /* Lrun_init_array */ -;; FIXME: There are currently no program termination routines executed for -;; msp430. -#if 0 -#if Lrun_fini_array -;; Ensure global C++ destructors in .fini_array are called on exit -;; by registering __crt0_run_fini_array with atexit. -START_CRT_FUNC 0700 register_fini_array - - mov_ #__crt0_run_fini_array, R12 - call_ #atexit - -END_CRT_FUNC register_fini_array -#endif /* Lrun_fini_array */ -#endif /* 0 */ #if Lmain ;; This function is always included and calls main(). -- 2.43.0