From: Mike Frysinger <vapier@gentoo.org>
To: newlib@sourceware.org
Subject: [PATCH 4/5] libgloss: msp430: delete custom .S.o rule
Date: Tue, 26 Dec 2023 22:24:52 -0500 [thread overview]
Message-ID: <20231227032453.13546-4-vapier@gentoo.org> (raw)
In-Reply-To: <20231227032453.13546-1-vapier@gentoo.org>
This was added to specify -Wa,-gdwarf2 when compiling the assembly
files. Considering the size of these .S files, it seems unnecessary
overkill and complicates the build system. All but one of these
compile down to 6 or fewer lines, and those hardly need extra debug
for anyone who is poking msp430 assembly. The 1 file that is larger
than that (crt_move_highdata.S) is still <15 insns.
This will also simplify merging it into the top-level Makefile.
---
libgloss/msp430/Makefile.in | 4 ----
1 file changed, 4 deletions(-)
diff --git a/libgloss/msp430/Makefile.in b/libgloss/msp430/Makefile.in
index ccf94dc1625f..62c8a280bcaa 100644
--- a/libgloss/msp430/Makefile.in
+++ b/libgloss/msp430/Makefile.in
@@ -96,10 +96,6 @@ CRT_OBJS = \
all: $(CRT) $(SIM_BSP) $(LIB_NOSYS) $(LIB_CRT) copy_scripts_to_objdir
-# Override .S.o rule to pass assembler debugging flags
-.S.o:
- $(CC) -Wa,-gdwarf2 -Wa,-I$(srcdir) $(CFLAGS_FOR_TARGET) $(INCLUDES) $(CFLAGS) -c $<
-
$(SIM_BSP): $(SIM_OBJS)
$(AR) $(ARFLAGS) $@ $?
$(RANLIB) $@
--
2.43.0
next prev parent reply other threads:[~2023-12-27 3:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 3:24 [PATCH 1/5] libgloss: msp430: delete outdated/wrong code Mike Frysinger
2023-12-27 3:24 ` [PATCH 2/5] libgloss: msp430: delete stub crt_init.o Mike Frysinger
2023-12-27 3:24 ` [PATCH 3/5] libgloss: msp430: split up crt0.S source Mike Frysinger
2023-12-27 3:24 ` Mike Frysinger [this message]
2023-12-27 3:24 ` [PATCH 5/5] libgloss: merge msp430 into top-level Makefile Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231227032453.13546-4-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).