From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) by sourceware.org (Postfix) with ESMTPS id 8E4E13858C50 for ; Tue, 12 Jul 2022 16:38:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8E4E13858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embedded-brains.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embedded-brains.de Received: from sslproxy01.your-server.de ([78.46.139.224]) by dedi548.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oBIuA-0009ef-4l for newlib@sourceware.org; Tue, 12 Jul 2022 18:38:34 +0200 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBIuA-0004p5-BB for newlib@sourceware.org; Tue, 12 Jul 2022 18:38:34 +0200 Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 0D3E348013D for ; Tue, 12 Jul 2022 18:38:34 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id KRN2FJV0GMFX for ; Tue, 12 Jul 2022 18:38:33 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id A9BA9480152 for ; Tue, 12 Jul 2022 18:38:33 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id B0SqVEj4uNPw for ; Tue, 12 Jul 2022 18:38:33 +0200 (CEST) Received: from [10.10.171.6] (unknown [10.10.171.6]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 6D92848013D for ; Tue, 12 Jul 2022 18:38:33 +0200 (CEST) Message-ID: <29672b0c-34bf-6015-ea8d-9fb8c3c09f2e@embedded-brains.de> Date: Tue, 12 Jul 2022 18:38:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: Fw: [PATCH 03/14] Add _REENT_ERRNO(ptr) Content-Language: en-US To: newlib@sourceware.org References: <20220621124931.36450-1-sebastian.huber@embedded-brains.de> <20220621124931.36450-4-sebastian.huber@embedded-brains.de> From: Sebastian Huber In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.103.6/26599/Tue Jul 12 10:00:48 2022) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 16:38:38 -0000 On 12/07/2022 18:11, Corinna Vinschen wrote: > On Jun 23 12:55, Sebastian Huber wrote: >> On 21/06/2022 16:41, C Howland wrote: >>>> ------------------------------ >>>> *From:* Newlib on >>>> behalf of Sebastian Huber >>>> *Sent:* Tuesday, June 21, 2022 8:49 AM >>>> *To:*newlib@sourceware.org >>>> *Subject:* [PATCH 03/14] Add _REENT_ERRNO(ptr) >>>> >>>> >>>> >>>> From: Matt Joyce >>>> >>>> Add a _REENT_ERRNO() macro to encapsulate the access to the >>>> _errno member of struct reent. This will help to replace the >>>> structure member with a thread-local storage object in a follow >>>> up patch. >>>> --- >>>> >>> There already exists an __errno_r() macro that does the very same fun= ction >>> (defined in sys/errno.h). (Its use, however, is limited, only being = used >>> in files under iconv/lib.) Having the same thing done both ways prob= ably >>> doesn't make sense. The new name is more consistent with the rest of= the >>> things being done, while the old name is established and errno is a m= ore >>> specialized case. It probably would be a good idea to either >>> 1) use __errno_r() instead of creating _REENT_ERRNO() or >>> 2) replace __errno_r() with _REENT_ERRNO() as part of adding the lat= ter. >> I would not remove an existing macro, so option 1) would be preferred = by me. > Really? Your followup patches introduce a lot of new _REENT_foo macros= , > so defining one of them with a different name doesn't make a lot of sen= se, > does it? There are lots of *_r() functions (for example _strdup_r()) so I assumed=20 that this __errno_r() might be used outside of Newlib. >=20 > Either all these macros should be called __foo_r(), or __errno_r() shou= ld > actually be removed or at least be defined in terms of _REENT_errno(), > if you really think we should keep it. =20 The original patch defined __errno_r() like this: #define __errno_r(ptr) _REENT_ERRNO(ptr) I think naming of the new _REENT_*() macros is quite consistent with the=20 stuff we already have in . > Given that it's used only in > iconv/lib kind of shows that it was never meant for consumption outside > newlib anyway, isn't it? What about renaming the existing __errno_r() uses in Newlib to=20 _REENT_ERRNO() with a definition of __errno_r() in for=20 potential users outside of Newlib? --=20 embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.huber@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht M=C3=BCnchen Registernummer: HRB 157899 Vertretungsberechtigte Gesch=C3=A4ftsf=C3=BChrer: Peter Rasmussen, Thomas= D=C3=B6rfler Unsere Datenschutzerkl=C3=A4rung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/