From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7029 invoked by alias); 25 Aug 2017 07:23:20 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 6342 invoked by uid 89); 25 Aug 2017 07:23:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:sk:smtpbg3, Hx-spam-relays-external:sk:smtpbg3, HX-HELO:sk:smtpbg3, H*r:sk:smtpbg3 X-HELO: smtpbg303.qq.com Received: from smtpbg303.qq.com (HELO smtpbg303.qq.com) (184.105.206.26) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Aug 2017 07:23:14 +0000 X-QQ-mid: esmtp11t1503645779tvmd60pgm Received: from [192.168.1.102] (unknown [114.212.116.37]) by esmtp4.qq.com (ESMTP) with id ; Fri, 25 Aug 2017 15:22:58 +0800 (CST) X-QQ-SSF: 0100000000000030FH101F00000000W X-QQ-FEAT: f1ydyWWHrWttEMzeSD3BFZi5CKyVYRzliXbatlJGa5S1ycJnkcjVbKBjMpen5 W3ibWZ9aPrNyhjVdpI9mM5AkYAs4AZQYoYTvMkSu7IG1WnL3Jn5jeB+4qANFzdyhsBngIr/ c8FepXQpTx3QbO3qZLNdiBIso/rQF4MwK+pPDKaBRsfH1THuTVww3JWFU6Eu7AcxQcf9LqX rbRUkDvX1Q06l7Wk0ZzfD3ZAkf87BAP/8R6i3f0Iy0fMoHFBxDzzZVhT0Ca6iC25ctwcWzJ PQXA== X-QQ-GoodBg: 0 Subject: Re: [PATCH v2 2/2] Port strnstr.c to newlib. To: Sebastian Huber , newlib@sourceware.org Cc: gedare@rtems.org, joel@rtems.org, christian.mauderer@embedded-brains.de References: <1503641725-11948-1-git-send-email-1473996754@qq.com> <1503641725-11948-2-git-send-email-1473996754@qq.com> <5a878b0f-ddca-d997-3f3e-28312838f075@embedded-brains.de> From: Sichen Zhao <1473996754@qq.com> Message-ID: <2dff1cfb-0225-f8ab-3add-bbcf9e60ed99@qq.com> Date: Fri, 25 Aug 2017 07:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <5a878b0f-ddca-d997-3f3e-28312838f075@embedded-brains.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-QQ-SENDSIZE: 520 X-QQ-FName: 5E4027928A4B4C21A22C613C0020C5A4 X-QQ-LocalIP: 10.198.131.167 X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00876.txt.bz2 > On 25/08/17 08:15, Sichen Zhao wrote: > >> --- >> newlib/libc/include/string.h | 3 +++ >> newlib/libc/string/Makefile.am | 1 + >> newlib/libc/string/strnstr.c | 13 ++++++------- >> 3 files changed, 10 insertions(+), 7 deletions(-) >> >> diff --git a/newlib/libc/include/string.h b/newlib/libc/include/string.h >> index 7833aa1..304d8a5 100644 >> --- a/newlib/libc/include/string.h >> +++ b/newlib/libc/include/string.h >> @@ -121,6 +121,9 @@ size_t _EXFUN(strnlen,(const char *, size_t)); >> #if __BSD_VISIBLE >> char *_EXFUN(strsep,(char **, const char *)); >> #endif >> +#if __BSD_VISIBLE >> +char *_EXFUN(strnstr,(const char *, const char *, size_t)); >> +#endif > > I would rather use the FreeBSD prototype: > > #if __BSD_VISIBLE > char *strnstr(const char *, const char *, size_t) __pure; > #endif > > This makes the strnstr.c modifications unnecessary. I think the > _EXFUN() stuff is deprecated. > Ok, i see.